test: allow testing uid and gid separately

cjihrig · cjihrig · commit b9abeeccc0c7 · 2017-01-09T12:31:52.000-05:00
This commit lets the uid and gid options of spawn() to be tested independently of one another based on the user's uid and gid. Fixes: #10646 PR-URL: #10647 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
diff --git a/test/parallel/test-child-process-uid-gid.js b/test/parallel/test-child-process-uid-gid.js
@@ -2,18 +2,16 @@
 const common = require('../common');
 const assert = require('assert');
 const spawn = require('child_process').spawn;
-
-if (!common.isWindows && process.getuid() === 0) {
-  common.skip('as this test should not be run as `root`');
-  return;
-}
-
 const expectedError = common.isWindows ? /\bENOTSUP\b/ : /\bEPERM\b/;
 
-assert.throws(() => {
-  spawn('echo', ['fhqwhgads'], {uid: 0});
-}, expectedError);
+if (common.isWindows || process.getuid() !== 0) {
+  assert.throws(() => {
+    spawn('echo', ['fhqwhgads'], {uid: 0});
+  }, expectedError);
+}
 
-assert.throws(() => {
-  spawn('echo', ['fhqwhgads'], {gid: 0});
-}, expectedError);
+if (common.isWindows || !process.getgroups().some((gid) => gid === 0)) {
+  assert.throws(() => {
+    spawn('echo', ['fhqwhgads'], {gid: 0});
+  }, expectedError);
+}
