Revert 3e2a2a7. Always send a HTTP/1.1 status line to the client.

bnoordhuis · bnoordhuis · commit b62ecdc5bbee · 2011-07-07T23:54:13.000+02:00
diff --git a/lib/http.js b/lib/http.js
@@ -771,8 +771,6 @@ function ServerResponse(req) {
     this.useChunkedEncodingByDefault = false;
     this.shouldKeepAlive = false;
   }
-
-  this._httpVersion = req.httpVersion;
 }
 util.inherits(ServerResponse, OutgoingMessage);
 
@@ -833,9 +831,8 @@ ServerResponse.prototype.writeHead = function(statusCode) {
     headers = obj;
   }
 
-  var statusLine = 'HTTP/' + this._httpVersion
-                 + ' ' + statusCode.toString()
-                 + ' ' + reasonPhrase + CRLF;
+  var statusLine = 'HTTP/1.1 ' + statusCode.toString() + ' ' +
+                   reasonPhrase + CRLF;
 
   if (statusCode === 204 || statusCode === 304 ||
       (100 <= statusCode && statusCode <= 199)) {
diff --git a/test/simple/test-http-1.0.js b/test/simple/test-http-1.0.js
@@ -119,7 +119,7 @@ function test(handler, request_generator, response_validator) {
   }
 
   function response_validator(server_response, client_got_eof, timed_out) {
-    var expected_response = ("HTTP/1.0 200 OK\r\n"
+    var expected_response = ("HTTP/1.1 200 OK\r\n"
         + "Content-Type: text/plain\r\n"
         + "Connection: close\r\n"
         + "\r\n"

Original file line number	Diff line number	Diff line change
`@@ -771,8 +771,6 @@ function ServerResponse(req) {`
`771`	`771`	`this.useChunkedEncodingByDefault = false;`
`772`	`772`	`this.shouldKeepAlive = false;`
`773`	`773`	`}`
`774`		`-`
`775`		`- this._httpVersion = req.httpVersion;`
`776`	`774`	`}`
`777`	`775`	`util.inherits(ServerResponse, OutgoingMessage);`
`778`	`776`
`@@ -833,9 +831,8 @@ ServerResponse.prototype.writeHead = function(statusCode) {`
`833`	`831`	`headers = obj;`
`834`	`832`	`}`
`835`	`833`
`836`		`- var statusLine = 'HTTP/' + this._httpVersion`
`837`		`- + ' ' + statusCode.toString()`
`838`		`- + ' ' + reasonPhrase + CRLF;`
	`834`	`+ var statusLine = 'HTTP/1.1 ' + statusCode.toString() + ' ' +`
	`835`	`+ reasonPhrase + CRLF;`
`839`	`836`
`840`	`837`	`if (statusCode === 204 \|\| statusCode === 304 \|\|`
`841`	`838`	`(100 <= statusCode && statusCode <= 199)) {`
Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ function test(handler, request_generator, response_validator) {`
`119`	`119`	`}`
`120`	`120`
`121`	`121`	`function response_validator(server_response, client_got_eof, timed_out) {`
`122`		`- var expected_response = ("HTTP/1.0 200 OK\r\n"`
	`122`	`+ var expected_response = ("HTTP/1.1 200 OK\r\n"`
`123`	`123`	`+ "Content-Type: text/plain\r\n"`
`124`	`124`	`+ "Connection: close\r\n"`
`125`	`125`	`+ "\r\n"`