src: make edge names in BaseObjects more descriptive in heap snapshots

joyeecheung · joyeecheung · commit ae4391eeb017 · 2023-02-04T02:16:19.000+01:00
Previously these were named "wrapper" and "wrapped", which can be
somewhat difficult to understand. This patch renames them to
"javascript_to_native" and "native_to_javascript".
diff --git a/src/memory_tracker-inl.h b/src/memory_tracker-inl.h
@@ -318,8 +318,8 @@ MemoryRetainerNode* MemoryTracker::AddNode(const MemoryRetainer* retainer,
   if (CurrentNode() != nullptr) graph_->AddEdge(CurrentNode(), n, edge_name);
 
   if (n->JSWrapperNode() != nullptr) {
-    graph_->AddEdge(n, n->JSWrapperNode(), "wrapped");
-    graph_->AddEdge(n->JSWrapperNode(), n, "wrapper");
+    graph_->AddEdge(n, n->JSWrapperNode(), "native_to_javascript");
+    graph_->AddEdge(n->JSWrapperNode(), n, "javascript_to_native");
   }
 
   return n;

Original file line number	Diff line number	Diff line change
`@@ -318,8 +318,8 @@ MemoryRetainerNode* MemoryTracker::AddNode(const MemoryRetainer* retainer,`
`318`	`318`	`if (CurrentNode() != nullptr) graph_->AddEdge(CurrentNode(), n, edge_name);`
`319`	`319`
`320`	`320`	`if (n->JSWrapperNode() != nullptr) {`
`321`		`- graph_->AddEdge(n, n->JSWrapperNode(), "wrapped");`
`322`		`- graph_->AddEdge(n->JSWrapperNode(), n, "wrapper");`
	`321`	`+ graph_->AddEdge(n, n->JSWrapperNode(), "native_to_javascript");`
	`322`	`+ graph_->AddEdge(n->JSWrapperNode(), n, "javascript_to_native");`
`323`	`323`	`}`
`324`	`324`
`325`	`325`	`return n;`