repl: fix tab completion of inspector module

targos · targos · commit a6f3e8f3fe65 · 2018-03-23T08:55:15.000+01:00
Correctly check for the presence of the inspector module before adding it to the builtin libs list. PR-URL: #19505 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/internal/modules/cjs/helpers.js b/lib/internal/modules/cjs/helpers.js
@@ -104,7 +104,7 @@ const builtinLibs = [
   'stream', 'string_decoder', 'tls', 'tty', 'url', 'util', 'v8', 'vm', 'zlib'
 ];
 
-if (typeof process.binding('inspector').connect === 'function') {
+if (typeof process.binding('inspector').open === 'function') {
   builtinLibs.push('inspector');
   builtinLibs.sort();
 }
diff --git a/test/parallel/test-module-cjs-helpers.js b/test/parallel/test-module-cjs-helpers.js
@@ -0,0 +1,11 @@
+'use strict';
+// Flags: --expose-internals
+
+require('../common');
+const assert = require('assert');
+const { builtinLibs } = require('internal/modules/cjs/helpers');
+
+const hasInspector = process.config.variables.v8_enable_inspector === 1;
+
+const expectedLibs = hasInspector ? 32 : 31;
+assert.strictEqual(builtinLibs.length, expectedLibs);

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ const builtinLibs = [`
`104`	`104`	`'stream', 'string_decoder', 'tls', 'tty', 'url', 'util', 'v8', 'vm', 'zlib'`
`105`	`105`	`];`
`106`	`106`
`107`		`-if (typeof process.binding('inspector').connect === 'function') {`
	`107`	`+if (typeof process.binding('inspector').open === 'function') {`
`108`	`108`	`builtinLibs.push('inspector');`
`109`	`109`	`builtinLibs.sort();`
`110`	`110`	`}`