fixup: compat paused

ronag · ronag · commit 906fd310dab6 · 2019-12-21T08:51:47.000+01:00
diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js
@@ -28,6 +28,7 @@ const {
   ObjectDefineProperty,
   ObjectSetPrototypeOf,
   SymbolAsyncIterator,
+  Symbol
 } = primordials;
 
 module.exports = Readable;
@@ -51,6 +52,8 @@ const {
   ERR_STREAM_UNSHIFT_AFTER_END_EVENT
 } = require('internal/errors').codes;
 
+const kPaused = Symbol('kPaused');
+
 // Lazy loaded to improve the startup performance.
 let StringDecoder;
 let createReadableStreamAsyncIterator;
@@ -126,7 +129,7 @@ function ReadableState(options, stream, isDuplex) {
   this.emittedReadable = false;
   this.readableListening = false;
   this.resumeScheduled = false;
-  this.paused = null;
+  this[kPaused] = null;
 
   // True if the error was already emitted and should not be thrown again
   this.errorEmitted = false;
@@ -173,6 +176,16 @@ ObjectDefineProperty(ReadableState.prototype, 'pipesCount', {
   }
 });
 
+// Legacy property for `paused`
+ObjectDefineProperty(ReadableState.prototype, 'paused', {
+  get() {
+    return this[kPaused] !== false;
+  },
+  set(value) {
+    this[kPaused] = Boolean(value);
+  }
+});
+
 function Readable(options) {
   if (!(this instanceof Readable))
     return new Readable(options);
@@ -368,7 +381,7 @@ function chunkInvalid(state, chunk) {
 
 
 Readable.prototype.isPaused = function() {
-  return this._readableState.paused === true;
+  return this._readableState[kPaused] === true;
 };
 
 // Backwards compatibility.
@@ -967,7 +980,7 @@ function updateReadableListening(self) {
   const state = self._readableState;
   state.readableListening = self.listenerCount('readable') > 0;
 
-  if (state.resumeScheduled && state.paused === false) {
+  if (state.resumeScheduled && state[kPaused] === false) {
     // Flowing needs to be set to true now, otherwise
     // the upcoming resume will not flow.
     state.flowing = true;
@@ -997,7 +1010,7 @@ Readable.prototype.resume = function() {
     state.flowing = !state.readableListening;
     resume(this, state);
   }
-  state.paused = false;
+  state[kPaused] = false;
   return this;
 };
 
@@ -1028,7 +1041,7 @@ Readable.prototype.pause = function() {
     this._readableState.flowing = false;
     this.emit('pause');
   }
-  this._readableState.paused = true;
+  this._readableState[kPaused] = true;
   return this;
 };
 
diff --git a/test/parallel/test-stream-readable-pause-and-resume.js b/test/parallel/test-stream-readable-pause-and-resume.js
@@ -53,6 +53,6 @@ function readAndPause() {
   readable.pause();
 
   process.nextTick(function() {
-    assert(readable.isPaused()); // Throws.
+    assert(readable.isPaused());
   });
 }

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,6 @@ function readAndPause() {`
`53`	`53`	`readable.pause();`
`54`	`54`
`55`	`55`	`process.nextTick(function() {`
`56`		`- assert(readable.isPaused()); // Throws.`
	`56`	`+ assert(readable.isPaused());`
`57`	`57`	`});`
`58`	`58`	`}`