util: fix wrong usage of Error.prepareStackTrace

szuend · addaleax · commit 8c0fcdc5906d · 2019-04-16T10:29:10.000+02:00
The return value of Error.prepareStackTrace will become the result of Error.stack accesses. Setting Error.stack inside this callback relies on the fact that the magic get accessor detects the change in the middle of formatting, and is unnecessary in this instance. Refs: v8#96
diff --git a/lib/internal/util.js b/lib/internal/util.js
@@ -347,7 +347,7 @@ function isInsideNodeModules() {
     // the perf implications should be okay.
     getStructuredStack = runInNewContext(`(function() {
       Error.prepareStackTrace = function(err, trace) {
-        err.stack = trace;
+        return trace;
       };
       Error.stackTraceLimit = Infinity;
 
