lib: Prevent leaking arguments in several places.

ChALkeR · ChALkeR · commit 8bf79b428416 · 2015-05-24T22:18:30.000+03:00
diff --git a/lib/console.js b/lib/console.js
@@ -1,6 +1,7 @@
 'use strict';
 
 const util = require('util');
+const assert = require('assert');
 
 function Console(stdout, stderr) {
   if (!(this instanceof Console)) {
@@ -83,8 +84,11 @@ Console.prototype.trace = function trace() {
 
 Console.prototype.assert = function(expression) {
   if (!expression) {
-    var arr = Array.prototype.slice.call(arguments, 1);
-    require('assert').ok(false, util.format.apply(this, arr));
+    var argsleft = arguments.length - 1;
+    const arr = new Array(argsleft > 0 ? argsleft : 0);
+    while (argsleft-- > 0) arr[argsleft] = arguments[argsleft + 1];
+
+    assert.ok(false, util.format.apply(this, arr));
   }
 };
 
diff --git a/lib/path.js b/lib/path.js
@@ -185,14 +185,13 @@ win32.isAbsolute = function(path) {
 };
 
 win32.join = function() {
-  function f(p) {
-    if (typeof p !== 'string') {
-      throw new TypeError('Arguments to path.join must be strings');
-    }
-    return p;
+  const paths = new Array(arguments.length);
+  for (var i = 0; i < arguments.length; i++) {
+     if (typeof arguments[i] !== 'string') {
+       throw new TypeError('Arguments to path.join must be strings');
+     }
+     paths[i] = arguments[i];
   }
-
-  var paths = Array.prototype.filter.call(arguments, f);
   var joined = paths.join('\\');
 
   // Make sure that the joined path doesn't start with two slashes, because
diff --git a/lib/util.js b/lib/util.js
@@ -15,8 +15,11 @@ exports.format = function(f) {
 
   if (arguments.length === 1) return f;
 
+  var argsleft = arguments.length;
+  const args = new Array(argsleft);
+  while (argsleft--) args[argsleft] = arguments[argsleft];
+
   var i = 1;
-  var args = arguments;
   var len = args.length;
   var str = String(f).replace(formatRegExp, function(x) {
     if (x === '%%') return '%';
