perf_hooks: add resourcetiming test parallel

RafaelGSS · RafaelGSS · commit 8aebe6e5807a · 2022-04-10T19:40:22.000-03:00
diff --git a/lib/internal/perf/observe.js b/lib/internal/perf/observe.js
@@ -91,6 +91,7 @@ const kSupportedEntryTypes = ObjectFreeze([
 // Performance timeline entry Buffers
 let markEntryBuffer = [];
 let measureEntryBuffer = [];
+let resourceTimingBuffer = [];
 const kMaxPerformanceEntryBuffers = 1e6;
 const kClearPerformanceEntryBuffers = ObjectFreeze({
   'mark': 'performance.clearMarks',
@@ -343,6 +344,7 @@ function enqueue(entry) {
   } else if (entryType === 'measure') {
     buffer = measureEntryBuffer;
   } else {
+    buffer = resourceTimingBuffer;
     return;
   }
 
@@ -367,16 +369,19 @@ function enqueue(entry) {
 }
 
 function clearEntriesFromBuffer(type, name) {
-  if (type !== 'mark' && type !== 'measure') {
+  if (type !== 'mark' && type !== 'measure' && type !== 'resource') {
     return;
   }
 
   if (type === 'mark') {
     markEntryBuffer = name === undefined ?
       [] : ArrayPrototypeFilter(markEntryBuffer, (entry) => entry.name !== name);
-  } else {
+  } else if (type === 'measure') {
     measureEntryBuffer = name === undefined ?
       [] : ArrayPrototypeFilter(measureEntryBuffer, (entry) => entry.name !== name);
+  } else {
+    resourceTimingBuffer = name === undefined ?
+      [] : ArrayPrototypeFilter(resourceTimingBuffer, (entry) => entry.name !== name);
   }
 }
 
@@ -386,11 +391,13 @@ function filterBufferMapByNameAndType(name, type) {
     bufferList = markEntryBuffer;
   } else if (type === 'measure') {
     bufferList = measureEntryBuffer;
+  } else if (type === 'resource') {
+    bufferList = resourceTimingBuffer;
   } else if (type !== undefined) {
     // Unrecognized type;
     return [];
   } else {
-    bufferList = ArrayPrototypeConcat(markEntryBuffer, measureEntryBuffer);
+    bufferList = ArrayPrototypeConcat(markEntryBuffer, measureEntryBuffer, resourceTimingBuffer);
   }
   if (name !== undefined) {
     bufferList = ArrayPrototypeFilter(bufferList, (buffer) => buffer.name === name);
diff --git a/lib/perf_hooks.js b/lib/perf_hooks.js
@@ -9,7 +9,7 @@ const {
 } = internalBinding('performance');
 
 const { PerformanceEntry } = require('internal/perf/performance_entry');
-const { PerformanceResourceTiming } = require('internal/perf/performance_resource_timing')
+const { PerformanceResourceTiming } = require('internal/perf/resource_timing')
 const {
   PerformanceObserver,
   PerformanceObserverEntryList,
diff --git a/test/parallel/test-perf-hooks-resourcetiming.js b/test/parallel/test-perf-hooks-resourcetiming.js
@@ -0,0 +1,18 @@
+'use strict';
+
+const assert = require('assert');
+const {
+  PerformanceObserver,
+  PerformanceEntry,
+  PerformanceResourceTiming,
+  performance: {
+    clearResourceTimings
+  },
+} = require('perf_hooks');
+
+assert(PerformanceObserver);
+assert(PerformanceEntry);
+assert(PerformanceResourceTiming);
+assert(clearResourceTimings);
+
+// TODO:continue once `markResourceTiming` is done
