test: remove common.skipIfInspectorEnabled()

Trott · targos · commit 7cf75af74491 · 2019-11-08T13:52:43.000+01:00
common.skipIfInspectorEnabled() is only used once in all of the tests. The test is more clear (in my opinion, at least) without the abstraction so put the check directly in the test. Additionally, it honestly looks like an error (which is how I noticed it in the first place) and that someone mistyped the far more common skipIfInspectorDisabled(). PR-URL: #29993 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
diff --git a/test/common/index.js b/test/common/index.js
@@ -651,12 +651,6 @@ function skipIfInspectorDisabled() {
   }
 }
 
-function skipIfInspectorEnabled() {
-  if (process.features.inspector) {
-    skip('V8 inspector is enabled');
-  }
-}
-
 function skipIfReportDisabled() {
   if (!process.config.variables.node_report) {
     skip('Diagnostic reporting is disabled');
@@ -789,7 +783,6 @@ module.exports = {
   skipIf32Bits,
   skipIfEslintMissing,
   skipIfInspectorDisabled,
-  skipIfInspectorEnabled,
   skipIfReportDisabled,
   skipIfWorker,
 
diff --git a/test/parallel/test-coverage-with-inspector-disabled.js b/test/parallel/test-coverage-with-inspector-disabled.js
@@ -1,7 +1,9 @@
 'use strict';
 
 const common = require('../common');
-common.skipIfInspectorEnabled();
+if (process.features.inspector) {
+  common.skip('V8 inspector is enabled');
+}
 
 const fixtures = require('../common/fixtures');
 const assert = require('assert');
