src: usage of modernize-use-equals-default

yashLadha · addaleax · commit 7c74702c15a2 · 2020-09-22T11:23:21.000+02:00
Update the destructor and constructor calls to use the default member function. This will bascially enable the compiler to do better optimization as the functions as explicitly defined as trivial. Refs: https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-equals-default.html PR-URL: #34807 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/src/node_file.cc b/src/node_file.cc
@@ -126,9 +126,9 @@ void FSContinuationData::MemoryInfo(MemoryTracker* tracker) const {
   tracker->TrackField("paths", paths_);
 }
 
-FileHandleReadWrap::~FileHandleReadWrap() {}
+FileHandleReadWrap::~FileHandleReadWrap() = default;
 
-FSReqBase::~FSReqBase() {}
+FSReqBase::~FSReqBase() = default;
 
 void FSReqBase::MemoryInfo(MemoryTracker* tracker) const {
   tracker->TrackField("continuation_data", continuation_data_);

Original file line number	Diff line number	Diff line change
`@@ -126,9 +126,9 @@ void FSContinuationData::MemoryInfo(MemoryTracker* tracker) const {`
`126`	`126`	`tracker->TrackField("paths", paths_);`
`127`	`127`	`}`
`128`	`128`
`129`		`-FileHandleReadWrap::~FileHandleReadWrap() {}`
	`129`	`+FileHandleReadWrap::~FileHandleReadWrap() = default;`
`130`	`130`
`131`		`-FSReqBase::~FSReqBase() {}`
	`131`	`+FSReqBase::~FSReqBase() = default;`
`132`	`132`
`133`	`133`	`void FSReqBase::MemoryInfo(MemoryTracker* tracker) const {`
`134`	`134`	`tracker->TrackField("continuation_data", continuation_data_);`