test: use the correct parameter order on assert.strictEqual()

lrdcasimir · rvagg · commit 780118a078de · 2018-11-28T11:26:39.000+11:00
The parameter order for assert.strictEqual() should be actual, expected rather than expected, actual which can make test failure messages confusing. This change reverses the order of the assertion to match the documented parameter order. PR-URL: #23520 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
diff --git a/test/pummel/test-net-many-clients.js b/test/pummel/test-net-many-clients.js
@@ -70,8 +70,8 @@ function runClient(callback) {
 
   client.on('close', function(had_error) {
     console.log('.');
-    assert.strictEqual(false, had_error);
-    assert.strictEqual(bytes, client.recved.length);
+    assert.strictEqual(had_error, false);
+    assert.strictEqual(client.recved.length, bytes);
 
     if (client.fd) {
       console.log(client.fd);
@@ -96,6 +96,6 @@ server.listen(common.PORT, function() {
 });
 
 process.on('exit', function() {
-  assert.strictEqual(connections_per_client * concurrency, total_connections);
+  assert.strictEqual(total_connections, connections_per_client * concurrency);
   console.log('\nokay!');
 });
