napi: supress invalid coverity leak message

mhdawson · mhdawson · commit 76cf2cf194aa · 2017-04-03T12:39:29.000-04:00
Coverity was complaining that finalizer was being
leaked in this method, however it should be
freed when the buffer is finalized so I believe
the message is invalid.

Add the required comments to suppress the warning.
diff --git a/src/node_api.cc b/src/node_api.cc
@@ -2274,6 +2274,10 @@ napi_status napi_create_external_buffer(napi_env env,
 
   *result = v8impl::JsValueFromV8LocalValue(maybe.ToLocalChecked());
   return GET_RETURN_STATUS();
+  // Tell coverity that 'finalizer' should not be freed when we return
+  // as it will be deleted when the buffer to which it is associated
+  // is finalized.
+  // coverity[leaked_storage]
 }
 
 napi_status napi_create_buffer_copy(napi_env env,

Original file line number	Diff line number	Diff line change
`@@ -2274,6 +2274,10 @@ napi_status napi_create_external_buffer(napi_env env,`
`2274`	`2274`
`2275`	`2275`	`*result = v8impl::JsValueFromV8LocalValue(maybe.ToLocalChecked());`
`2276`	`2276`	`return GET_RETURN_STATUS();`
	`2277`	`+ // Tell coverity that 'finalizer' should not be freed when we return`
	`2278`	`+ // as it will be deleted when the buffer to which it is associated`
	`2279`	`+ // is finalized.`
	`2280`	`+ // coverity[leaked_storage]`
`2277`	`2281`	`}`
`2278`	`2282`
`2279`	`2283`	`napi_status napi_create_buffer_copy(napi_env env,`