process: throw on non-function to nextTick()

yorkie · cjihrig · commit 72e3dd9f43c1 · 2015-11-18T10:52:01.000-05:00
This commit causes process.nextTick() to throw when its callback argument is not a function. PR-URL: #3860 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
diff --git a/src/node.js b/src/node.js
@@ -486,6 +486,8 @@
     }
 
     function nextTick(callback) {
+      if (typeof callback !== 'function')
+        throw new TypeError('callback is not a function');
       // on the way out, don't bother. it won't get fired anyway.
       if (process._exiting)
         return;
diff --git a/test/parallel/test-next-tick-errors.js b/test/parallel/test-next-tick-errors.js
@@ -20,6 +20,22 @@ process.nextTick(function() {
   order.push('C');
 });
 
+function testNextTickWith(val) {
+  assert.throws(
+    function() {
+      process.nextTick(val);
+    },
+    TypeError
+  );
+}
+
+testNextTickWith(false);
+testNextTickWith(true);
+testNextTickWith(1);
+testNextTickWith('str');
+testNextTickWith({});
+testNextTickWith([]);
+
 process.on('uncaughtException', function() {
   if (!exceptionHandled) {
     exceptionHandled = true;

Original file line number	Diff line number	Diff line change
`@@ -486,6 +486,8 @@`
`486`	`486`	`}`
`487`	`487`
`488`	`488`	`function nextTick(callback) {`
	`489`	`+ if (typeof callback !== 'function')`
	`490`	`+ throw new TypeError('callback is not a function');`
`489`	`491`	`// on the way out, don't bother. it won't get fired anyway.`
`490`	`492`	`if (process._exiting)`
`491`	`493`	`return;`