Skip to content

Commit 6d61175

Browse files
sygtargos
authored and
nodejs-github-bot
committed
deps: V8: backport 1d3362c55396
Original commit message: [float16array] Turn flag on by default Float16Array has shipped in blink since M135. It is unlikely it'll unship by now, so turn the flag on by default. Bug: 42203953 Change-Id: Ibd9de407b8810dd7bcdb46194fe04fc290ff8fb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6513988 Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#100104} Refs: v8/v8@1d3362c Co-authored-by: Michaël Zasso <targos@protonmail.com> PR-URL: #58230 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> PR-URL: #58064 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
1 parent 9747735 commit 6d61175

4 files changed

Lines changed: 10 additions & 9 deletions

File tree

‎common.gypi‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.11',
41+
'v8_embedder_string': '-node.12',
4242

4343
##### V8 defaults for Node.js #####
4444

‎deps/v8/src/flags/flag-definitions.h‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -294,9 +294,7 @@ DEFINE_BOOL(js_shipping, true, "enable all shipped JavaScript features")
294294

295295
// Features that are complete (but still behind the --harmony flag).
296296
#define HARMONY_STAGED_BASE(V)
297-
#define JAVASCRIPT_STAGED_FEATURES_BASE(V) \
298-
V(js_float16array, \
299-
"Float16Array, Math.f16round, DataView.getFloat16, DataView.setFloat16")
297+
#define JAVASCRIPT_STAGED_FEATURES_BASE(V)
300298

301299
#ifdef V8_INTL_SUPPORT
302300
#define HARMONY_STAGED(V) \
@@ -320,7 +318,9 @@ DEFINE_BOOL(js_shipping, true, "enable all shipped JavaScript features")
320318
V(js_atomics_pause, "Atomics.pause") \
321319
V(js_error_iserror, "Error.isError") \
322320
V(js_regexp_escape, "RegExp.escape") \
323-
V(js_explicit_resource_management, "explicit resource management")
321+
V(js_explicit_resource_management, "explicit resource management") \
322+
V(js_float16array, \
323+
"Float16Array, Math.f16round, DataView.getFloat16, DataView.setFloat16")
324324

325325
#ifdef V8_INTL_SUPPORT
326326
#define HARMONY_SHIPPING(V) HARMONY_SHIPPING_BASE(V)

‎deps/v8/src/init/bootstrapper.cc‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5210,6 +5210,11 @@ DirectHandle<JSFunction> Genesis::InstallTypedArray(
52105210
GetCorrespondingRabGsabElementsKind(elements_kind), 0);
52115211
rab_gsab_initial_map->SetConstructor(*result);
52125212

5213+
if (rab_gsab_initial_map_index == Context::RAB_GSAB_FLOAT16_ARRAY_MAP_INDEX &&
5214+
v8_flags.js_float16array) {
5215+
LOG(isolate(), MapDetails(*rab_gsab_initial_map));
5216+
}
5217+
52135218
native_context()->set(rab_gsab_initial_map_index, *rab_gsab_initial_map,
52145219
UPDATE_WRITE_BARRIER, kReleaseStore);
52155220
Map::SetPrototype(isolate(), rab_gsab_initial_map, prototype);

‎deps/v8/test/test262/test262.status‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2431,7 +2431,6 @@
24312431
'staging/sm/Temporal/PlainMonthDay/from-coptic': [FAIL],
24322432
'staging/sm/Temporal/PlainMonthDay/from-gregory': [FAIL],
24332433
'staging/sm/Temporal/PlainMonthDay/result-not-after-1972-dec-31': [FAIL],
2434-
'staging/sm/Math/f16round': [FAIL],
24352434
'staging/sm/RegExp/unicode-ignoreCase': [FAIL],
24362435
'staging/sm/String/string-code-point-upper-lower-mapping': [FAIL],
24372436
'staging/sm/String/string-upper-lower-mapping': [FAIL],
@@ -2442,13 +2441,10 @@
24422441
'staging/sm/TypedArray/prototype-constructor-identity': [FAIL],
24432442
'staging/sm/TypedArray/set-detached-bigint': [FAIL],
24442443
'staging/sm/TypedArray/seal-and-freeze': [FAIL],
2445-
'staging/sm/TypedArray/sort-negative-nan': [FAIL],
2446-
'staging/sm/TypedArray/sort_small': [FAIL],
24472444
'staging/sm/TypedArray/test-integrity-level': [FAIL],
24482445
'staging/sm/TypedArray/test-integrity-level-detached': [FAIL],
24492446
'staging/sm/TypedArray/toReversed-detached': [FAIL],
24502447
'staging/sm/TypedArray/toSorted-detached': [FAIL],
2451-
'staging/sm/TypedArray/toString': [FAIL],
24522448
'staging/sm/TypedArray/with': [FAIL],
24532449
'staging/sm/TypedArray/with-detached': [FAIL],
24542450
}],

0 commit comments

Comments
 (0)