url: simplify loop in parser

tniessen · MylesBorins · commit 6a3bf3c36b08 · 2018-03-20T15:47:52.000Z
PR-URL: #18468 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/url.js b/lib/url.js
@@ -880,7 +880,7 @@ Url.prototype.resolveObject = function resolveObject(relative) {
 
   // if the path is allowed to go above the root, restore leading ..s
   if (!mustEndAbs && !removeAllDots) {
-    for (; up--; up) {
+    while (up--) {
       srcPath.unshift('..');
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -880,7 +880,7 @@ Url.prototype.resolveObject = function resolveObject(relative) {`
`880`	`880`
`881`	`881`	`// if the path is allowed to go above the root, restore leading ..s`
`882`	`882`	`if (!mustEndAbs && !removeAllDots) {`
`883`		`- for (; up--; up) {`
	`883`	`+ while (up--) {`
`884`	`884`	`srcPath.unshift('..');`
`885`	`885`	`}`
`886`	`886`	`}`