|
| 1 | +'use strict'; |
| 2 | + |
| 3 | +const common = require('../common'); |
| 4 | +const { isMainThread } = require('worker_threads'); |
| 5 | + |
| 6 | +if (!isMainThread) { |
| 7 | + common.skip('This test only works on a main thread'); |
| 8 | +} |
| 9 | + |
| 10 | +// This test ensures that --permission-audit does not deny fs.lstat() and |
| 11 | +// fs.symlink(), whose permission checks live in the JavaScript layer, while |
| 12 | +// --permission still denies them. Audit mode must publish the denial through |
| 13 | +// the diagnostics channel and let the operation continue. Each API is covered |
| 14 | +// in its three flavours (sync, callback and promise), since every flavour |
| 15 | +// carries its own copy of the check. |
| 16 | + |
| 17 | +const assert = require('assert'); |
| 18 | +const { spawnSync } = require('child_process'); |
| 19 | +const { test } = require('node:test'); |
| 20 | +const fixtures = require('../common/fixtures'); |
| 21 | +const tmpdir = require('../common/tmpdir'); |
| 22 | + |
| 23 | +const blockedFile = fixtures.path('permission', 'deny', 'protected-file.md'); |
| 24 | + |
| 25 | +function run(flag, { op, name }) { |
| 26 | + const childScript = ` |
| 27 | + const dc = require('node:diagnostics_channel'); |
| 28 | + const msgs = []; |
| 29 | + dc.subscribe('node:permission-model:fs', (m) => msgs.push({ |
| 30 | + permission: m.permission, |
| 31 | + resource: m.resource, |
| 32 | + })); |
| 33 | + (async () => { |
| 34 | + try { |
| 35 | + await (${op}); |
| 36 | + console.log('RESULT NO_THROW'); |
| 37 | + } catch (e) { |
| 38 | + console.log('RESULT THREW ' + e.code); |
| 39 | + } |
| 40 | + console.log('AUDIT ' + JSON.stringify(msgs)); |
| 41 | + })(); |
| 42 | + `; |
| 43 | + |
| 44 | + const env = { |
| 45 | + ...process.env, |
| 46 | + BLOCKED_FILE: blockedFile, |
| 47 | + LINK_PATH: tmpdir.resolve(`audit-symlink-${flag.replace(/\W/g, '')}-${name}`), |
| 48 | + }; |
| 49 | + const { status, stdout, stderr } = spawnSync( |
| 50 | + process.execPath, |
| 51 | + [flag, '-e', childScript], |
| 52 | + { encoding: 'utf8', env }, |
| 53 | + ); |
| 54 | + assert.strictEqual(status, 0, stderr); |
| 55 | + const lines = stdout.split('\n'); |
| 56 | + const resultLine = lines.find((l) => l.startsWith('RESULT ')); |
| 57 | + assert.ok(resultLine, stdout); |
| 58 | + const auditLine = lines.find((l) => l.startsWith('AUDIT ')); |
| 59 | + assert.ok(auditLine, stdout); |
| 60 | + return { |
| 61 | + result: resultLine.replace('RESULT ', ''), |
| 62 | + msgs: JSON.parse(auditLine.replace('AUDIT ', '')), |
| 63 | + }; |
| 64 | +} |
| 65 | + |
| 66 | +const lstatOps = [ |
| 67 | + { |
| 68 | + name: 'lstatSync', |
| 69 | + api: 'fs.lstatSync()', |
| 70 | + op: 'require("node:fs").lstatSync(process.env.BLOCKED_FILE)', |
| 71 | + }, |
| 72 | + { |
| 73 | + name: 'lstatCallback', |
| 74 | + api: 'fs.lstat()', |
| 75 | + op: 'new Promise((resolve, reject) => require("node:fs").lstat(' + |
| 76 | + 'process.env.BLOCKED_FILE, (err) => err ? reject(err) : resolve()))', |
| 77 | + }, |
| 78 | + { |
| 79 | + name: 'lstatPromises', |
| 80 | + api: 'fsPromises.lstat()', |
| 81 | + op: 'require("node:fs").promises.lstat(process.env.BLOCKED_FILE)', |
| 82 | + }, |
| 83 | +]; |
| 84 | + |
| 85 | +const symlinkOps = [ |
| 86 | + { |
| 87 | + name: 'symlinkSync', |
| 88 | + api: 'fs.symlinkSync()', |
| 89 | + op: 'require("node:fs").symlinkSync(process.env.BLOCKED_FILE, ' + |
| 90 | + 'process.env.LINK_PATH)', |
| 91 | + }, |
| 92 | + { |
| 93 | + name: 'symlinkCallback', |
| 94 | + api: 'fs.symlink()', |
| 95 | + op: 'new Promise((resolve, reject) => require("node:fs").symlink(' + |
| 96 | + 'process.env.BLOCKED_FILE, process.env.LINK_PATH, ' + |
| 97 | + '(err) => err ? reject(err) : resolve()))', |
| 98 | + }, |
| 99 | + { |
| 100 | + name: 'symlinkPromises', |
| 101 | + api: 'fsPromises.symlink()', |
| 102 | + op: 'require("node:fs").promises.symlink(process.env.BLOCKED_FILE, ' + |
| 103 | + 'process.env.LINK_PATH)', |
| 104 | + }, |
| 105 | +]; |
| 106 | + |
| 107 | +tmpdir.refresh(); |
| 108 | + |
| 109 | +for (const entry of lstatOps) { |
| 110 | + test(`audit mode does not deny ${entry.api} but logs the denial`, () => { |
| 111 | + const { result, msgs } = run('--permission-audit', entry); |
| 112 | + assert.strictEqual(result, 'NO_THROW'); |
| 113 | + assert.strictEqual(msgs.length, 1); |
| 114 | + assert.strictEqual(msgs[0].permission, 'FileSystemRead'); |
| 115 | + assert.ok(msgs[0].resource.endsWith('protected-file.md')); |
| 116 | + }); |
| 117 | + |
| 118 | + test(`enforce mode still denies ${entry.api}`, () => { |
| 119 | + const { result } = run('--permission', entry); |
| 120 | + assert.strictEqual(result, 'THREW ERR_ACCESS_DENIED'); |
| 121 | + }); |
| 122 | +} |
| 123 | + |
| 124 | +for (const entry of symlinkOps) { |
| 125 | + test(`audit mode does not deny ${entry.api} but logs the denial`, (t) => { |
| 126 | + if (!common.canCreateSymLink()) { |
| 127 | + return t.skip('insufficient privileges to create symlinks'); |
| 128 | + } |
| 129 | + const { result, msgs } = run('--permission-audit', entry); |
| 130 | + assert.strictEqual(result, 'NO_THROW'); |
| 131 | + assert.ok( |
| 132 | + msgs.some((m) => m.permission === 'FileSystem'), |
| 133 | + JSON.stringify(msgs), |
| 134 | + ); |
| 135 | + }); |
| 136 | + |
| 137 | + test(`enforce mode still denies ${entry.api}`, (t) => { |
| 138 | + if (!common.canCreateSymLink()) { |
| 139 | + return t.skip('insufficient privileges to create symlinks'); |
| 140 | + } |
| 141 | + const { result } = run('--permission', entry); |
| 142 | + assert.strictEqual(result, 'THREW ERR_ACCESS_DENIED'); |
| 143 | + }); |
| 144 | +} |
0 commit comments