Skip to content

Commit 5f40989

Browse files
TrottTrott
committed
test: refactor beforeExit tests
Combine and rename tests for the `beforeExit` event on `process`. The naming now more closely follows the de facto conventions of the project. The two tests were very similar and do not seem to benefit from being separate.
1 parent 398229a commit 5f40989

2 files changed

Lines changed: 14 additions & 15 deletions

File tree

‎test/parallel/test-process-before-exit.js‎

Lines changed: 0 additions & 14 deletions
This file was deleted.

test/parallel/test-beforeexit-event.js renamed to test/parallel/test-process-beforeexit.js

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,19 @@ function tryListen() {
2121
.listen(0)
2222
.on('listening', common.mustCall(function() {
2323
this.close();
24-
process.on('beforeExit', common.mustCall(() => {}));
24+
process.once('beforeExit', common.mustCall(tryRepeatedTimer));
2525
}));
2626
}
27+
28+
// test that a function invoked from the beforeExit handler can use a timer
29+
// to keep the event loop open, which can use another timer to keep the event
30+
// loop open, etc.
31+
function tryRepeatedTimer() {
32+
const N = 5;
33+
let n = 0;
34+
const repeatedTimer = common.mustCall(function() {
35+
if (++n < N)
36+
setTimeout(repeatedTimer, 1);
37+
}, N);
38+
setTimeout(repeatedTimer, 1);
39+
}

0 commit comments

Comments
 (0)