test: close fds properly in tests

joyeecheung · joyeecheung · commit 5ed5a8696128 · 2021-06-01T16:38:17.000+08:00
Otherwise the unclosed fd may keep the file open which makes
subsequent rmdir attempts failed at exit.
diff --git a/test/parallel/test-fs-writefile-with-fd.js b/test/parallel/test-fs-writefile-with-fd.js
@@ -66,6 +66,7 @@ tmpdir.refresh();
 
   fs.open(file, 'r', common.mustSucceed((fd) => {
     fs.writeFile(fd, 'World', common.expectsError(expectedError));
+    fs.closeSync(fd);
   }));
 }
 
@@ -76,8 +77,11 @@ tmpdir.refresh();
   const file = join(tmpdir.path, 'test.txt');
 
   fs.open(file, 'w', common.mustSucceed((fd) => {
-    fs.writeFile(fd, 'World', { signal }, common.expectsError({
-      name: 'AbortError'
+    fs.writeFile(fd, 'World', { signal }, common.mustCall((err) => {
+      fs.closeSync(fd);
+      common.expectsError({
+        name: 'AbortError'
+      })(err);
     }));
   }));
 
