net: remove ADDRCONFIG DNS hint on Windows

bzoz · MylesBorins · commit 581fe1f59f8f · 2018-01-23T00:16:09.000-08:00
On Windows setting ADDRCONFIG causes localhost resolution to fail if there are no network connections. This removes that flag on Windows. Fixes: #17641 PR-URL: #17662 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
diff --git a/lib/net.js b/lib/net.js
@@ -1088,7 +1088,10 @@ function lookupAndConnect(self, options) {
     hints: options.hints || 0
   };
 
-  if (dnsopts.family !== 4 && dnsopts.family !== 6 && dnsopts.hints === 0) {
+  if (process.platform !== 'win32' &&
+      dnsopts.family !== 4 &&
+      dnsopts.family !== 6 &&
+      dnsopts.hints === 0) {
     dnsopts.hints = dns.ADDRCONFIG;
   }
 
