http: remove all internal listeners

ShogunPanda · ShogunPanda · commit 56ba9abf6d62 · 2022-06-27T12:28:26.000Z
diff --git a/lib/_http_server.js b/lib/_http_server.js
@@ -762,7 +762,10 @@ const requestHeaderFieldsTooLargeResponse = Buffer.from(
 function socketOnError(e) {
   // Ignore further errors
   this.removeListener('error', socketOnError);
-  this.on('error', noop);
+
+  if (!this.listenerCount('error')) {
+    this.on('error', noop);
+  }
 
   if (!this.server.emit('clientError', e, this)) {
     if (this.writable && this.bytesWritten === 0) {
diff --git a/test/parallel/test-http-socket-listeners.js b/test/parallel/test-http-socket-listeners.js
@@ -0,0 +1,30 @@
+'use strict';
+
+const common = require('../common');
+const http = require('http');
+const net = require('net');
+
+const server = http.createServer((req, res) => {
+  res.writeHead(200);
+  res.end('response');
+});
+
+server.on('clientError', common.mustCallAtLeast(() => {}, 1));
+process.on('warning', common.mustNotCall());
+
+server.listen(0, () => {
+  const client = net.createConnection({ port: server.address().port });
+
+  client.on('connect', () => {
+    for (let i = 0; i < 20; i++) {
+      setTimeout(() => {
+        client.write('*\r\n');
+      }, common.platformTimeout(i * 10));
+    }
+
+    setTimeout(() => {
+      client.end();
+      server.close();
+    }, common.platformTimeout(1000));
+  });
+});
