Skip to content

Commit 4ec5c44

Browse files
targostargos
committed
deps: update v8 to 4.4.63.25
Includes cherry-picks for: * JitCodeEvent patch: https://crrev.com/f7969b1d5a55e66237221a463daf422ac7611788 * argparse patch: https://crrev.com/44bc918458481d60b08d5566f0f31a79e39b85d7
1 parent 235036e commit 4ec5c44

38 files changed

Lines changed: 1075 additions & 237 deletions

‎deps/v8/include/v8-version.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#define V8_MAJOR_VERSION 4
1212
#define V8_MINOR_VERSION 4
1313
#define V8_BUILD_NUMBER 63
14-
#define V8_PATCH_LEVEL 12
14+
#define V8_PATCH_LEVEL 25
1515

1616
// Use 1 for candidates and 0 otherwise.
1717
// (Boolean macro values are not supported by all preprocessors.)

‎deps/v8/src/api.cc‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -345,12 +345,14 @@ StartupData V8::CreateSnapshotDataBlob(const char* custom_source) {
345345
base::ElapsedTimer timer;
346346
timer.Start();
347347
Isolate::Scope isolate_scope(isolate);
348+
internal_isolate->set_creating_default_snapshot(true);
348349
internal_isolate->Init(NULL);
349350
Persistent<Context> context;
350351
i::Snapshot::Metadata metadata;
351352
{
352353
HandleScope handle_scope(isolate);
353354
Handle<Context> new_context = Context::New(isolate);
355+
internal_isolate->set_creating_default_snapshot(false);
354356
context.Reset(isolate, new_context);
355357
if (custom_source != NULL) {
356358
metadata.set_embeds_script(true);
@@ -379,7 +381,7 @@ StartupData V8::CreateSnapshotDataBlob(const char* custom_source) {
379381
i::SnapshotByteSink context_sink;
380382
i::PartialSerializer context_ser(internal_isolate, &ser, &context_sink);
381383
context_ser.Serialize(&raw_context);
382-
ser.SerializeWeakReferences();
384+
ser.SerializeWeakReferencesAndDeferred();
383385

384386
result = i::Snapshot::CreateSnapshotBlob(ser, context_ser, metadata);
385387
}

‎deps/v8/src/arm/assembler-arm-inl.h‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -432,9 +432,7 @@ void Assembler::CheckBuffer() {
432432
if (buffer_space() <= kGap) {
433433
GrowBuffer();
434434
}
435-
if (pc_offset() >= next_buffer_check_) {
436-
CheckConstPool(false, true);
437-
}
435+
MaybeCheckConstPool();
438436
}
439437

440438

‎deps/v8/src/arm/assembler-arm.cc‎

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1298,7 +1298,7 @@ void Assembler::addrmod5(Instr instr, CRegister crd, const MemOperand& x) {
12981298
}
12991299

13001300

1301-
int Assembler::branch_offset(Label* L, bool jump_elimination_allowed) {
1301+
int Assembler::branch_offset(Label* L) {
13021302
int target_pos;
13031303
if (L->is_bound()) {
13041304
target_pos = L->pos();
@@ -1315,7 +1315,8 @@ int Assembler::branch_offset(Label* L, bool jump_elimination_allowed) {
13151315

13161316
// Block the emission of the constant pool, since the branch instruction must
13171317
// be emitted at the pc offset recorded by the label.
1318-
BlockConstPoolFor(1);
1318+
if (!is_const_pool_blocked()) BlockConstPoolFor(1);
1319+
13191320
return target_pos - (pc_offset() + kPcLoadDelta);
13201321
}
13211322

@@ -1367,6 +1368,24 @@ void Assembler::bx(Register target, Condition cond) { // v5 and above, plus v4t
13671368
}
13681369

13691370

1371+
void Assembler::b(Label* L, Condition cond) {
1372+
CheckBuffer();
1373+
b(branch_offset(L), cond);
1374+
}
1375+
1376+
1377+
void Assembler::bl(Label* L, Condition cond) {
1378+
CheckBuffer();
1379+
bl(branch_offset(L), cond);
1380+
}
1381+
1382+
1383+
void Assembler::blx(Label* L) {
1384+
CheckBuffer();
1385+
blx(branch_offset(L));
1386+
}
1387+
1388+
13701389
// Data-processing instructions.
13711390

13721391
void Assembler::and_(Register dst, Register src1, const Operand& src2,

‎deps/v8/src/arm/assembler-arm.h‎

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -746,7 +746,7 @@ class Assembler : public AssemblerBase {
746746
// Returns the branch offset to the given label from the current code position
747747
// Links the label to the current position if it is still unbound
748748
// Manages the jump elimination optimization if the second parameter is true.
749-
int branch_offset(Label* L, bool jump_elimination_allowed);
749+
int branch_offset(Label* L);
750750

751751
// Returns true if the given pc address is the start of a constant pool load
752752
// instruction sequence.
@@ -852,13 +852,11 @@ class Assembler : public AssemblerBase {
852852
void bx(Register target, Condition cond = al); // v5 and above, plus v4t
853853

854854
// Convenience branch instructions using labels
855-
void b(Label* L, Condition cond = al) {
856-
b(branch_offset(L, cond == al), cond);
857-
}
858-
void b(Condition cond, Label* L) { b(branch_offset(L, cond == al), cond); }
859-
void bl(Label* L, Condition cond = al) { bl(branch_offset(L, false), cond); }
860-
void bl(Condition cond, Label* L) { bl(branch_offset(L, false), cond); }
861-
void blx(Label* L) { blx(branch_offset(L, false)); } // v5 and above
855+
void b(Label* L, Condition cond = al);
856+
void b(Condition cond, Label* L) { b(L, cond); }
857+
void bl(Label* L, Condition cond = al);
858+
void bl(Condition cond, Label* L) { bl(L, cond); }
859+
void blx(Label* L); // v5 and above
862860

863861
// Data-processing instructions
864862

@@ -1536,6 +1534,12 @@ class Assembler : public AssemblerBase {
15361534
// Check if is time to emit a constant pool.
15371535
void CheckConstPool(bool force_emit, bool require_jump);
15381536

1537+
void MaybeCheckConstPool() {
1538+
if (pc_offset() >= next_buffer_check_) {
1539+
CheckConstPool(false, true);
1540+
}
1541+
}
1542+
15391543
// Allocate a constant pool of the correct size for the generated code.
15401544
Handle<ConstantPoolArray> NewConstantPool(Isolate* isolate);
15411545

‎deps/v8/src/arm64/code-stubs-arm64.cc‎

Lines changed: 9 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -2286,27 +2286,16 @@ void RegExpExecStub::Generate(MacroAssembler* masm) {
22862286
Register last_match_info_elements = x21;
22872287
Register code_object = x22;
22882288

2289-
// TODO(jbramley): Is it necessary to preserve these? I don't think ARM does.
2290-
CPURegList used_callee_saved_registers(subject,
2291-
regexp_data,
2292-
last_match_info_elements,
2293-
code_object);
2294-
__ PushCPURegList(used_callee_saved_registers);
2295-
22962289
// Stack frame.
2297-
// jssp[0] : x19
2298-
// jssp[8] : x20
2299-
// jssp[16]: x21
2300-
// jssp[24]: x22
2301-
// jssp[32]: last_match_info (JSArray)
2302-
// jssp[40]: previous index
2303-
// jssp[48]: subject string
2304-
// jssp[56]: JSRegExp object
2305-
2306-
const int kLastMatchInfoOffset = 4 * kPointerSize;
2307-
const int kPreviousIndexOffset = 5 * kPointerSize;
2308-
const int kSubjectOffset = 6 * kPointerSize;
2309-
const int kJSRegExpOffset = 7 * kPointerSize;
2290+
// jssp[00]: last_match_info (JSArray)
2291+
// jssp[08]: previous index
2292+
// jssp[16]: subject string
2293+
// jssp[24]: JSRegExp object
2294+
2295+
const int kLastMatchInfoOffset = 0 * kPointerSize;
2296+
const int kPreviousIndexOffset = 1 * kPointerSize;
2297+
const int kSubjectOffset = 2 * kPointerSize;
2298+
const int kJSRegExpOffset = 3 * kPointerSize;
23102299

23112300
// Ensure that a RegExp stack is allocated.
23122301
ExternalReference address_of_regexp_stack_memory_address =
@@ -2673,7 +2662,6 @@ void RegExpExecStub::Generate(MacroAssembler* masm) {
26732662

26742663
// Return last match info.
26752664
__ Peek(x0, kLastMatchInfoOffset);
2676-
__ PopCPURegList(used_callee_saved_registers);
26772665
// Drop the 4 arguments of the stub from the stack.
26782666
__ Drop(4);
26792667
__ Ret();
@@ -2696,13 +2684,11 @@ void RegExpExecStub::Generate(MacroAssembler* masm) {
26962684

26972685
__ Bind(&failure);
26982686
__ Mov(x0, Operand(isolate()->factory()->null_value()));
2699-
__ PopCPURegList(used_callee_saved_registers);
27002687
// Drop the 4 arguments of the stub from the stack.
27012688
__ Drop(4);
27022689
__ Ret();
27032690

27042691
__ Bind(&runtime);
2705-
__ PopCPURegList(used_callee_saved_registers);
27062692
__ TailCallRuntime(Runtime::kRegExpExec, 4, 1);
27072693

27082694
// Deferred code for string handling.

‎deps/v8/src/bootstrapper.cc‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2813,6 +2813,7 @@ void Genesis::TransferNamedProperties(Handle<JSObject> from,
28132813
if (value->IsPropertyCell()) {
28142814
value = handle(PropertyCell::cast(*value)->value(), isolate());
28152815
}
2816+
if (value->IsTheHole()) continue;
28162817
PropertyDetails details = properties->DetailsAt(i);
28172818
DCHECK_EQ(kData, details.kind());
28182819
JSObject::AddProperty(to, key, value, details.attributes());

‎deps/v8/src/compiler/arm/code-generator-arm.cc‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -316,6 +316,8 @@ void CodeGenerator::AssembleDeconstructActivationRecord() {
316316
void CodeGenerator::AssembleArchInstruction(Instruction* instr) {
317317
ArmOperandConverter i(this, instr);
318318

319+
masm()->MaybeCheckConstPool();
320+
319321
switch (ArchOpcodeField::decode(instr->opcode())) {
320322
case kArchCallCodeObject: {
321323
EnsureSpaceForLazyDeopt();

‎deps/v8/src/flag-definitions.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ DEFINE_IMPLICATION(es_staging, harmony)
199199
#define HARMONY_STAGED(V) \
200200
V(harmony_rest_parameters, "harmony rest parameters") \
201201
V(harmony_spreadcalls, "harmony spread-calls") \
202-
V(harmony_tostring, "harmony toString") \
202+
V(harmony_tostring, "harmony toString")
203203

204204
// Features that are shipping (turned on by default, but internal flag remains).
205205
#define HARMONY_SHIPPING(V) \

‎deps/v8/src/ic/ic.cc‎

Lines changed: 43 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1112,7 +1112,39 @@ void LoadIC::UpdateCaches(LookupIterator* lookup) {
11121112
code = slow_stub();
11131113
}
11141114
} else {
1115-
code = ComputeHandler(lookup);
1115+
if (lookup->state() == LookupIterator::ACCESSOR) {
1116+
Handle<Object> accessors = lookup->GetAccessors();
1117+
Handle<Map> map = receiver_map();
1118+
if (accessors->IsExecutableAccessorInfo()) {
1119+
Handle<ExecutableAccessorInfo> info =
1120+
Handle<ExecutableAccessorInfo>::cast(accessors);
1121+
if ((v8::ToCData<Address>(info->getter()) != 0) &&
1122+
!ExecutableAccessorInfo::IsCompatibleReceiverMap(isolate(), info,
1123+
map)) {
1124+
TRACE_GENERIC_IC(isolate(), "LoadIC", "incompatible receiver type");
1125+
code = slow_stub();
1126+
}
1127+
} else if (accessors->IsAccessorPair()) {
1128+
Handle<Object> getter(Handle<AccessorPair>::cast(accessors)->getter(),
1129+
isolate());
1130+
Handle<JSObject> holder = lookup->GetHolder<JSObject>();
1131+
Handle<Object> receiver = lookup->GetReceiver();
1132+
if (getter->IsJSFunction() && holder->HasFastProperties()) {
1133+
Handle<JSFunction> function = Handle<JSFunction>::cast(getter);
1134+
if (receiver->IsJSObject() || function->IsBuiltin() ||
1135+
!is_sloppy(function->shared()->language_mode())) {
1136+
CallOptimization call_optimization(function);
1137+
if (call_optimization.is_simple_api_call() &&
1138+
!call_optimization.IsCompatibleReceiver(receiver, holder)) {
1139+
TRACE_GENERIC_IC(isolate(), "LoadIC",
1140+
"incompatible receiver type");
1141+
code = slow_stub();
1142+
}
1143+
}
1144+
}
1145+
}
1146+
}
1147+
if (code.is_null()) code = ComputeHandler(lookup);
11161148
}
11171149

11181150
PatchCache(lookup->name(), code);
@@ -1242,6 +1274,8 @@ Handle<Code> LoadIC::CompileHandler(LookupIterator* lookup,
12421274
if (v8::ToCData<Address>(info->getter()) == 0) break;
12431275
if (!ExecutableAccessorInfo::IsCompatibleReceiverMap(isolate(), info,
12441276
map)) {
1277+
// This case should be already handled in LoadIC::UpdateCaches.
1278+
UNREACHABLE();
12451279
break;
12461280
}
12471281
if (!holder->HasFastProperties()) break;
@@ -1262,10 +1296,14 @@ Handle<Code> LoadIC::CompileHandler(LookupIterator* lookup,
12621296
}
12631297
CallOptimization call_optimization(function);
12641298
NamedLoadHandlerCompiler compiler(isolate(), map, holder, cache_holder);
1265-
if (call_optimization.is_simple_api_call() &&
1266-
call_optimization.IsCompatibleReceiver(receiver, holder)) {
1267-
return compiler.CompileLoadCallback(lookup->name(), call_optimization,
1268-
lookup->GetAccessorIndex());
1299+
if (call_optimization.is_simple_api_call()) {
1300+
if (call_optimization.IsCompatibleReceiver(receiver, holder)) {
1301+
return compiler.CompileLoadCallback(
1302+
lookup->name(), call_optimization, lookup->GetAccessorIndex());
1303+
} else {
1304+
// This case should be already handled in LoadIC::UpdateCaches.
1305+
UNREACHABLE();
1306+
}
12691307
}
12701308
int expected_arguments =
12711309
function->shared()->internal_formal_parameter_count();

0 commit comments

Comments
 (0)