Skip to content

Commit 4bfbeff

Browse files
committed
dns: Add setServers into 'dns/promises'
1 parent 69041eb commit 4bfbeff

2 files changed

Lines changed: 38 additions & 1 deletion

File tree

lib/dns/promises.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
'use strict';
22

3-
module.exports = require('internal/dns/promises');
3+
const dnsPromises = require('internal/dns/promises');
4+
dnsPromises.setServers = require('dns').setServers;
5+
module.exports = dnsPromises;

test/parallel/test-dns-setservers-type-check.js

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,3 +85,38 @@ const promiseResolver = new dns.promises.Resolver();
8585
);
8686
});
8787
}
88+
89+
// This test for 'dns/promises'
90+
{
91+
const {
92+
setServers,
93+
resolve
94+
} = require('dns/promises');
95+
96+
// This should not throw any error.
97+
(async () => {
98+
const localhost = await resolve('localhost');
99+
setServers(localhost);
100+
})();
101+
102+
[
103+
[null],
104+
[undefined],
105+
[Number(addresses.DNS4_SERVER)],
106+
[
107+
{
108+
address: addresses.DNS4_SERVER
109+
}
110+
]
111+
].forEach((val) => {
112+
const errObj = {
113+
code: 'ERR_INVALID_ARG_TYPE',
114+
name: 'TypeError',
115+
message: 'The "servers[0]" argument must be of type string.' +
116+
common.invalidArgTypeHelper(val[0])
117+
};
118+
assert.throws(() => {
119+
setServers(val);
120+
}, errObj);
121+
});
122+
}

0 commit comments

Comments
 (0)