test: use npm sandbox in test-npm-install

joaocgreis · jasnell · commit 47863a5837ca · 2016-10-17T09:45:06.000-07:00
npm should run in a sandbox to avoid unwanted interactions. Without this change, npm would read the userconfig file $HOME/.npmrc which may contain configs that break this test. Fixes: #9074 PR-URL: #9079 Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/test/parallel/test-npm-install.js b/test/parallel/test-npm-install.js
@@ -11,6 +11,10 @@ const assert = require('assert');
 const fs = require('fs');
 
 common.refreshTmpDir();
+const npmSandbox = path.join(common.tmpDir, 'npm-sandbox');
+fs.mkdirSync(npmSandbox);
+const installDir = path.join(common.tmpDir, 'install-dir');
+fs.mkdirSync(installDir);
 
 const npmPath = path.join(
   common.testDir,
@@ -32,23 +36,26 @@ const pkgContent = JSON.stringify({
   }
 });
 
-const pkgPath = path.join(common.tmpDir, 'package.json');
+const pkgPath = path.join(installDir, 'package.json');
 
 fs.writeFileSync(pkgPath, pkgContent);
 
 const env = Object.create(process.env);
 env['PATH'] = path.dirname(process.execPath);
+env['NPM_CONFIG_PREFIX'] = path.join(npmSandbox, 'npm-prefix');
+env['NPM_CONFIG_TMP'] = path.join(npmSandbox, 'npm-tmp');
+env['HOME'] = path.join(npmSandbox, 'home');
 
 const proc = spawn(process.execPath, args, {
-  cwd: common.tmpDir,
+  cwd: installDir,
   env: env
 });
 
 function handleExit(code, signalCode) {
   assert.equal(code, 0, 'npm install should run without an error');
   assert.ok(signalCode === null, 'signalCode should be null');
   assert.doesNotThrow(function() {
-    fs.accessSync(common.tmpDir + '/node_modules/package-name');
+    fs.accessSync(installDir + '/node_modules/package-name');
   });
 }
 
