tools: enable no-useless-catch lint rule

cjihrig · BethGriggs · commit 4427e5a46c88 · 2019-05-10T20:10:28.000+01:00
This commit enables ESLint's no-useless-catch rule. PR-URL: #25236 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -222,6 +222,7 @@ module.exports = {
       variables: false,
     }],
     'no-useless-call': 'error',
+    'no-useless-catch': 'error',
     'no-useless-concat': 'error',
     'no-useless-constructor': 'error',
     'no-useless-escape': 'error',
diff --git a/lib/vm.js b/lib/vm.js
@@ -79,7 +79,7 @@ class Script extends ContextifyScript {
     // Calling `ReThrow()` on a native TryCatch does not generate a new
     // abort-on-uncaught-exception check. A dummy try/catch in JS land
     // protects against that.
-    try {
+    try { // eslint-disable-line no-useless-catch
       super(code,
             filename,
             lineOffset,
