lib: cleanup instance validation

VoltrexKeyva · web-flow · commit 404f44210849 · 2021-08-04T14:04:51.000+04:30
Cleaned up the `URLSearchParams`'s `this` validation to increase
readability by moving them to an extra helper function.
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -153,6 +153,11 @@ class URLContext {
   }
 }
 
+function isURLSearchParams(self) {
+  if (!self || !self[searchParams] || self[searchParams][searchParams])
+    throw new ERR_INVALID_THIS('URLSearchParams');
+}
+
 class URLSearchParams {
   // URL Standard says the default value is '', but as undefined and '' have
   // the same result, undefined is used to prevent unnecessary parsing.
@@ -222,9 +227,7 @@ class URLSearchParams {
   }
 
   [inspect.custom](recurseTimes, ctx) {
-    if (!this || !this[searchParams] || this[searchParams][searchParams]) {
-      throw new ERR_INVALID_THIS('URLSearchParams');
-    }
+    isURLSearchParams(this);
 
     if (typeof recurseTimes === 'number' && recurseTimes < 0)
       return ctx.stylize('[Object]', 'special');
@@ -259,9 +262,8 @@ class URLSearchParams {
   }
 
   append(name, value) {
-    if (!this || !this[searchParams] || this[searchParams][searchParams]) {
-      throw new ERR_INVALID_THIS('URLSearchParams');
-    }
+    isURLSearchParams(this);
+
     if (arguments.length < 2) {
       throw new ERR_MISSING_ARGS('name', 'value');
     }
@@ -273,9 +275,8 @@ class URLSearchParams {
   }
 
   delete(name) {
-    if (!this || !this[searchParams] || this[searchParams][searchParams]) {
-      throw new ERR_INVALID_THIS('URLSearchParams');
-    }
+    isURLSearchParams(this);
+
     if (arguments.length < 1) {
       throw new ERR_MISSING_ARGS('name');
     }
@@ -294,9 +295,8 @@ class URLSearchParams {
   }
 
   get(name) {
-    if (!this || !this[searchParams] || this[searchParams][searchParams]) {
-      throw new ERR_INVALID_THIS('URLSearchParams');
-    }
+    isURLSearchParams(this);
+
     if (arguments.length < 1) {
       throw new ERR_MISSING_ARGS('name');
     }
@@ -312,9 +312,8 @@ class URLSearchParams {
   }
 
   getAll(name) {
-    if (!this || !this[searchParams] || this[searchParams][searchParams]) {
-      throw new ERR_INVALID_THIS('URLSearchParams');
-    }
+    isURLSearchParams(this);
+
     if (arguments.length < 1) {
       throw new ERR_MISSING_ARGS('name');
     }
@@ -331,9 +330,8 @@ class URLSearchParams {
   }
 
   has(name) {
-    if (!this || !this[searchParams] || this[searchParams][searchParams]) {
-      throw new ERR_INVALID_THIS('URLSearchParams');
-    }
+    isURLSearchParams(this);
+
     if (arguments.length < 1) {
       throw new ERR_MISSING_ARGS('name');
     }
@@ -349,9 +347,8 @@ class URLSearchParams {
   }
 
   set(name, value) {
-    if (!this || !this[searchParams] || this[searchParams][searchParams]) {
-      throw new ERR_INVALID_THIS('URLSearchParams');
-    }
+    isURLSearchParams(this);
+
     if (arguments.length < 2) {
       throw new ERR_MISSING_ARGS('name', 'value');
     }
@@ -436,17 +433,13 @@ class URLSearchParams {
   // Define entries here rather than [Symbol.iterator] as the function name
   // must be set to `entries`.
   entries() {
-    if (!this || !this[searchParams] || this[searchParams][searchParams]) {
-      throw new ERR_INVALID_THIS('URLSearchParams');
-    }
+    isURLSearchParams(this);
 
     return createSearchParamsIterator(this, 'key+value');
   }
 
   forEach(callback, thisArg = undefined) {
-    if (!this || !this[searchParams] || this[searchParams][searchParams]) {
-      throw new ERR_INVALID_THIS('URLSearchParams');
-    }
+    isURLSearchParams(this);
     validateCallback(callback);
 
     let list = this[searchParams];
@@ -464,27 +457,21 @@ class URLSearchParams {
 
   // https://heycam.github.io/webidl/#es-iterable
   keys() {
-    if (!this || !this[searchParams] || this[searchParams][searchParams]) {
-      throw new ERR_INVALID_THIS('URLSearchParams');
-    }
+    isURLSearchParams(this);
 
     return createSearchParamsIterator(this, 'key');
   }
 
   values() {
-    if (!this || !this[searchParams] || this[searchParams][searchParams]) {
-      throw new ERR_INVALID_THIS('URLSearchParams');
-    }
+    isURLSearchParams(this);
 
     return createSearchParamsIterator(this, 'value');
   }
 
   // https://heycam.github.io/webidl/#es-stringifier
   // https://url.spec.whatwg.org/#urlsearchparams-stringification-behavior
   toString() {
-    if (!this || !this[searchParams] || this[searchParams][searchParams]) {
-      throw new ERR_INVALID_THIS('URLSearchParams');
-    }
+    isURLSearchParams(this);
 
     return serializeParams(this[searchParams]);
   }
