buffer: remove unnecessary argument check

targos · Fishrock123 · commit 3fcdf4e80a8f · 2016-10-11T12:26:38.000-04:00
In Buffer.prototype.compare, the first check makes sure that target is an instance of Buffer. The value cannot be falsy after that so we can safely get its length. PR-URL: #8552 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -529,7 +529,7 @@ Buffer.prototype.compare = function compare(target,
   if (start === undefined)
     start = 0;
   if (end === undefined)
-    end = target ? target.length : 0;
+    end = target.length;
   if (thisStart === undefined)
     thisStart = 0;
   if (thisEnd === undefined)
