events: reset the event target to null

lpinca · lpinca · commit 38a7c5cd121f · 2021-07-15T09:33:06.000+02:00
Allow an event to be dispatched multiple times by resetting the event
target to `null` when dispatch is complete.
diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js
@@ -464,7 +464,7 @@ class EventTarget {
     }
 
     if (event !== undefined)
-      event[kTarget] = undefined;
+      event[kTarget] = null;
   }
 
   [kCreateEvent](nodeValue, type) {
diff --git a/test/parallel/test-eventtarget.js b/test/parallel/test-eventtarget.js
@@ -162,6 +162,27 @@ let asyncTest = Promise.resolve();
   eventTarget.dispatchEvent(ev);
 }
 
+{
+  // Same event dispatched multiple times.
+  const event = new Event('foo');
+  const eventTarget1 = new EventTarget();
+  const eventTarget2 = new EventTarget();
+
+  eventTarget1.addEventListener('foo', common.mustCall((event) => {
+    strictEqual(event.target, eventTarget1);
+  }));
+
+  eventTarget2.addEventListener('foo', common.mustCall((event) => {
+    strictEqual(event.target, eventTarget2);
+  }));
+
+  eventTarget1.dispatchEvent(event);
+  strictEqual(event.target, null);
+
+  eventTarget2.dispatchEvent(event);
+  strictEqual(event.target, null);
+}
+
 {
   const eventTarget = new EventTarget();
   const event = new Event('foo', { cancelable: true });

Original file line number	Diff line number	Diff line change
`@@ -464,7 +464,7 @@ class EventTarget {`
`464`	`464`	`}`
`465`	`465`
`466`	`466`	`if (event !== undefined)`
`467`		`- event[kTarget] = undefined;`
	`467`	`+ event[kTarget] = null;`
`468`	`468`	`}`
`469`	`469`
`470`	`470`	`[kCreateEvent](nodeValue, type) {`