doc: fix order of AtExit callbacks in addons.md

danbev · danbev · commit 3731f60d0b71 · 2017-08-07T08:14:13.000+02:00
The sanity_check AtExit callback needs to come last to verify that the
other callbacks have been completed. This was not noticed before as this
code was not been executed.
diff --git a/doc/api/addons.md b/doc/api/addons.md
@@ -1109,10 +1109,10 @@ static void sanity_check(void*) {
 }
 
 void init(Local<Object> exports) {
-  AtExit(sanity_check);
   AtExit(at_exit_cb2, cookie);
   AtExit(at_exit_cb2, cookie);
   AtExit(at_exit_cb1, exports->GetIsolate());
+  AtExit(sanity_check);
 }
 
 NODE_MODULE(addon, init)

Original file line number	Diff line number	Diff line change
`@@ -1109,10 +1109,10 @@ static void sanity_check(void*) {`
`1109`	`1109`	`}`
`1110`	`1110`
`1111`	`1111`	`void init(Local<Object> exports) {`
`1112`		`- AtExit(sanity_check);`
`1113`	`1112`	`AtExit(at_exit_cb2, cookie);`
`1114`	`1113`	`AtExit(at_exit_cb2, cookie);`
`1115`	`1114`	`AtExit(at_exit_cb1, exports->GetIsolate());`
	`1115`	`+ AtExit(sanity_check);`
`1116`	`1116`	`}`
`1117`	`1117`
`1118`	`1118`	`NODE_MODULE(addon, init)`