net: skip chunk check on incoming data

lpinca · lpinca · commit 359b1aeab4a4 · 2018-03-25T19:21:53.000+02:00
Do not validate data chunks read from the socket handle as they are
guaranteed to be buffers and validation is costly.
diff --git a/lib/net.js b/lib/net.js
@@ -239,6 +239,10 @@ function Socket(options) {
   // For backwards compat do not emit close on destroy.
   options.emitClose = false;
 
+  // Data chunks read from the handle are always buffers so there is no need to
+  // validate them.
+  options.skipChunkCheck = true;
+
   // `DuplexBase` is just a slimmed down constructor for `Duplex` which allow
   // us to not inherit the "no-half-open enforcer" as there is already one in
   // place. Instances of `Socket` are still instances of `Duplex`, that is,
diff --git a/test/parallel/test-net-socket-skip-chunk-check.js b/test/parallel/test-net-socket-skip-chunk-check.js
@@ -0,0 +1,11 @@
+'use strict';
+require('../common');
+
+// This test ensures that `net.Socket` uses the `skipChunkCheck` option
+// when calling the `Readable` constructor.
+
+const { Socket } = require('net');
+const { strictEqual } = require('assert');
+
+const socket = new Socket();
+strictEqual(socket._readableState.skipChunkCheck, true);
