Skip to content

Commit 2c31e5b

Browse files
mhdawsonMyles Borins
authored andcommitted
test: skip pseudo-tty/no_dropped_stdio test
We had marked it as flaky but in some failures it hangs and does not seem to timeout, and or is reported as an error. Also add prefix to status file as it was missing. Also fix name of status file in testcfg.py. It was pointing to message.status instead of pseudo-tty.status. PR-URL: #8470 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
1 parent 9e8d1c7 commit 2c31e5b

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

test/pseudo-tty/pseudo-tty.status

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
prefix pseudo-tty
2+
13
[$system==aix]
24
# test issue only, covered under https://github.com/nodejs/node/issues/7973
3-
no_dropped_stdio : PASS, FLAKY
5+
no_dropped_stdio : SKIP

test/pseudo-tty/testcfg.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ def GetBuildRequirements(self):
152152
return ['sample', 'sample=shell']
153153

154154
def GetTestStatus(self, sections, defs):
155-
status_file = join(self.root, 'message.status')
155+
status_file = join(self.root, 'pseudo-tty.status')
156156
if exists(status_file):
157157
test.ReadConfigurationInto(status_file, sections, defs)
158158

0 commit comments

Comments
 (0)