src: fix external reference registration for new CFunction lifetime

joyeecheung · joyeecheung · commit 1c8bf439c8bd · 2026-05-21T17:28:49.000+02:00
Signed-off-by: Joyee Cheung &lt;joyeec9h3@gmail.com&gt;
diff --git a/src/node_external_reference.h b/src/node_external_reference.h
@@ -42,8 +42,7 @@ class ExternalReferenceRegistry {
   // Registers both the underlying function pointer
   // and the corresponding CFunctionInfo.
   void Register(const v8::CFunction& c_func) {
-    RegisterT(c_func.GetAddress());
-    RegisterT(c_func.GetTypeInfo());
+    RegisterT(&c_func);
   }
 
   // This can be called only once.
diff --git a/src/node_wasi.cc b/src/node_wasi.cc
@@ -234,7 +234,7 @@ void WASI::New(const FunctionCallbackInfo<Value>& args) {
 template <typename FT, FT F, typename R, typename... Args>
 void WASI::WasiFunction<FT, F, R, Args...>::SetFunction(
     Environment* env, const char* name, Local<FunctionTemplate> tmpl) {
-  auto c_function = CFunction::Make(FastCallback);
+  static auto c_function = CFunction::Make(FastCallback);
   Local<FunctionTemplate> t =
       FunctionTemplate::New(env->isolate(),
                             SlowCallback,

Original file line number	Diff line number	Diff line change
`@@ -42,8 +42,7 @@ class ExternalReferenceRegistry {`
`42`	`42`	`// Registers both the underlying function pointer`
`43`	`43`	`// and the corresponding CFunctionInfo.`
`44`	`44`	`void Register(const v8::CFunction& c_func) {`
`45`		`- RegisterT(c_func.GetAddress());`
`46`		`- RegisterT(c_func.GetTypeInfo());`
	`45`	`+ RegisterT(&c_func);`
`47`	`46`	`}`
`48`	`47`
`49`	`48`	`// This can be called only once.`