url: warn when operation requires ICU

aduh95 · aduh95 · commit 189677f9bf34 · 2020-09-24T17:43:36.000+02:00
diff --git a/src/node_url.cc b/src/node_url.cc
@@ -787,11 +787,13 @@ bool ToASCII(const std::string& input, std::string* output) {
 #else
 // Intentional non-ops if ICU is not present.
 bool ToUnicode(const std::string& input, std::string* output) {
+  std::cerr << "Warning: Cannot convert to unicode when intl is disabled!\n";
   *output = input;
   return true;
 }
 
 bool ToASCII(const std::string& input, std::string* output) {
+  std::cerr << "Warning: Cannot convert to ASCII when intl is disabled!\n";
   *output = input;
   return true;
 }

Original file line number	Diff line number	Diff line change
`@@ -787,11 +787,13 @@ bool ToASCII(const std::string& input, std::string* output) {`
`787`	`787`	`#else`
`788`	`788`	`// Intentional non-ops if ICU is not present.`
`789`	`789`	`bool ToUnicode(const std::string& input, std::string* output) {`
	`790`	`+ std::cerr << "Warning: Cannot convert to unicode when intl is disabled!\n";`
`790`	`791`	`*output = input;`
`791`	`792`	`return true;`
`792`	`793`	`}`
`793`	`794`
`794`	`795`	`bool ToASCII(const std::string& input, std::string* output) {`
	`796`	`+ std::cerr << "Warning: Cannot convert to ASCII when intl is disabled!\n";`
`795`	`797`	`*output = input;`
`796`	`798`	`return true;`
`797`	`799`	`}`