net: remove unnecessary variables

mscdex · evanlucas · commit 17b8381585d1 · 2016-08-24T08:36:49.000-05:00
V8 is smart enough to optimize the length property checking when iterating over an array with a for loop. PR-URL: #8112 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/net.js b/lib/net.js
@@ -60,9 +60,8 @@ exports.createServer = function(options, connectionListener) {
 // connect(path, [cb]);
 //
 exports.connect = exports.createConnection = function() {
-  const argsLen = arguments.length;
-  var args = new Array(argsLen);
-  for (var i = 0; i < argsLen; i++)
+  var args = new Array(arguments.length);
+  for (var i = 0; i < arguments.length; i++)
     args[i] = arguments[i];
   args = normalizeConnectArgs(args);
   debug('createConnection', args);
@@ -885,9 +884,8 @@ Socket.prototype.connect = function(options, cb) {
     // Old API:
     // connect(port, [host], [cb])
     // connect(path, [cb]);
-    const argsLen = arguments.length;
-    var args = new Array(argsLen);
-    for (var i = 0; i < argsLen; i++)
+    var args = new Array(arguments.length);
+    for (var i = 0; i < arguments.length; i++)
       args[i] = arguments[i];
     args = normalizeConnectArgs(args);
     return Socket.prototype.connect.apply(this, args);
