tools: lint for use of internalBinding()

cjihrig · BethGriggs · commit 1287f74c3196 · 2019-04-29T00:43:23.000+01:00
Use of process.binding() has largely been replaced by internalBinding(). This commit updates the custom crypto check ESLint rule to check for both process.binding() and internalBinding(). Refs: #24952 PR-URL: #25395 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
diff --git a/test/parallel/test-eslint-crypto-check.js b/test/parallel/test-eslint-crypto-check.js
@@ -19,6 +19,12 @@ new RuleTester().run('crypto-check', rule, {
       common.skip("missing crypto");
     }
     require("crypto");
+    `,
+    `
+    if (!common.hasCrypto) {
+      common.skip("missing crypto");
+    }
+    internalBinding("crypto");
     `
   ],
   invalid: [
@@ -51,6 +57,18 @@ new RuleTester().run('crypto-check', rule, {
               '}\n' +
               'if (common.foo) {}\n' +
               'require("crypto")'
+    },
+    {
+      code: 'require("common")\n' +
+            'if (common.foo) {}\n' +
+            'internalBinding("crypto")',
+      errors: [{ message }],
+      output: 'require("common")\n' +
+              'if (!common.hasCrypto) {' +
+              ' common.skip("missing crypto");' +
+              '}\n' +
+              'if (common.foo) {}\n' +
+              'internalBinding("crypto")'
     }
   ]
 });
diff --git a/tools/eslint-rules/rules-utils.js b/tools/eslint-rules/rules-utils.js
@@ -33,14 +33,15 @@ module.exports.isCommonModule = function(node) {
 
 /**
  * Returns true if any of the passed in modules are used in
- * binding calls.
+ * process.binding() or internalBinding() calls.
  */
 module.exports.isBinding = function(node, modules) {
-  if (node.callee.object) {
-    return node.callee.object.name === 'process' &&
-           node.callee.property.name === 'binding' &&
-           modules.includes(node.arguments[0].value);
-  }
+  const isProcessBinding = node.callee.object &&
+                           node.callee.object.name === 'process' &&
+                           node.callee.property.name === 'binding';
+
+  return (isProcessBinding || node.callee.name === 'internalBinding') &&
+         modules.includes(node.arguments[0].value);
 };
 
 /**
