src: omit unconvertible names in cjs_lexer::Parse

anonrig · aduh95 · commit 10f03e5958ef · 2026-06-21T00:20:27.000+02:00
Follow-up to aa25a0a. When an export or re-export name cannot be converted to a V8 string (e.g. on string allocation failure), omit that individual name and continue instead of bailing out of the whole preparse. A single pathological name no longer fails the module's exports preparse; the remaining names are still returned. Refs: #63885 Refs: #63323 Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> PR-URL: #63943 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
diff --git a/src/node_cjs_lexer.cc b/src/node_cjs_lexer.cc
@@ -67,25 +67,26 @@ void Parse(const FunctionCallbackInfo<Value>& args) {
 
   const auto& analysis = result.value();
 
-  // Convert exports to JS Set
+  // Convert exports to JS Set, omitting any name that cannot be turned into a
+  // V8 string (e.g. on string allocation failure) instead of aborting.
   Local<Set> exports_set = Set::New(isolate);
   for (const auto& exp : analysis.exports) {
     Local<String> exp_str;
-    if (!CreateString(isolate, exp).ToLocal(&exp_str) ||
+    if (CreateString(isolate, exp).ToLocal(&exp_str) &&
         exports_set->Add(context, exp_str).IsEmpty()) {
       return;
     }
   }
 
-  // Convert reexports to JS array using batch creation
+  // Convert reexports to JS array, omitting any name that cannot be turned into
+  // a V8 string.
   LocalVector<Value> reexports_vec(isolate);
   reexports_vec.reserve(analysis.re_exports.size());
   for (const auto& reexp : analysis.re_exports) {
     Local<String> reexp_str;
-    if (!CreateString(isolate, reexp).ToLocal(&reexp_str)) {
-      return;
+    if (CreateString(isolate, reexp).ToLocal(&reexp_str)) {
+      reexports_vec.push_back(reexp_str);
     }
-    reexports_vec.push_back(reexp_str);
   }
 
   // Create result array [exports (Set), reexports (Array)]
