tools: auto fix custom eslint rule for crypto-check.js

shobhitchittora · shobhitchittora · commit 1018b5bab9df · 2018-02-15T15:39:48.000+05:30
Review comments + updates test cases Refs : #16636
diff --git a/test/parallel/test-eslint-crypto-check.js b/test/parallel/test-eslint-crypto-check.js
@@ -12,32 +12,35 @@ new RuleTester().run('crypto-check', rule, {
   valid: [
     'foo',
     'crypto',
-    `if (!common.hasCrypto) {
-      common.skip();
+    `
+    if (!common.hasCrypto) {
+      common.skip("missing crypto");
     }
     require("crypto");
     `
   ],
   invalid: [
     {
-      code: 'require("crypto")',
+      code: 'require("common")\n' +
+            'require("crypto")',
       errors: [{ message }],
-      output:
-      `if (!common.hasCrypto) {
-        common.skip("missing crypto");
-      }
-      require("crypto");
-      `
+      output: 'require("common")\n' +
+              'if (!common.hasCrypto) {' +
+              ' common.skip("missing crypto");' +
+              '}\n' +
+              'require("crypto")'
     },
     {
-      code: 'if (common.foo) {} require("crypto")',
+      code: 'require("common")\n' + 
+            'if (common.foo) {}\n' +
+            'require("crypto")',
       errors: [{ message }],
-      output:
-      `if (!common.hasCrypto) {
-        common.skip("missing crypto");
-      }
-      require("crypto");
-      `
+      output: 'require("common")\n' +
+              'if (!common.hasCrypto) {' +
+              ' common.skip("missing crypto");' +
+              '}\n' +
+              'if (common.foo) {}\n' +
+              'require("crypto")'
     }
   ]
 });
diff --git a/tools/eslint-rules/crypto-check.js b/tools/eslint-rules/crypto-check.js
@@ -87,9 +87,9 @@ module.exports = function(context) {
           if (commonModuleNode) {
             return fixer.insertTextAfter(
               commonModuleNode,
-              `\nif (!common.hasCrypto) {
-                common.skip("missing crypto");
-              }`
+              '\nif (!common.hasCrypto) {' +
+              ' common.skip("missing crypto");' +
+              '}'
             );
           }
         }
diff --git a/tools/eslint-rules/rules-utils.js b/tools/eslint-rules/rules-utils.js
@@ -12,7 +12,7 @@ module.exports.isRequired = function(node, modules) {
     modules.includes(node.arguments[0].value);
 };
 
-/** 
+/**
 * Return true if common module is required
 * in AST Node under inspection
 */

Original file line number	Diff line number	Diff line change
`@@ -87,9 +87,9 @@ module.exports = function(context) {`
`87`	`87`	`if (commonModuleNode) {`
`88`	`88`	`return fixer.insertTextAfter(`
`89`	`89`	`commonModuleNode,`
`90`		- `\nif (!common.hasCrypto) {
`91`		`- common.skip("missing crypto");`
`92`		- }`
	`90`	`+ '\nif (!common.hasCrypto) {' +`
	`91`	`+ ' common.skip("missing crypto");' +`
	`92`	`+ '}'`
`93`	`93`	`);`
`94`	`94`	`}`
`95`	`95`	`}`