src: add missing TryCatch

verwaest · targos · commit 0d05f471f1ce · 2024-01-04T10:14:40.000+01:00
Otherwise re-entering V8 doesn't work as expected after exceptions
were thrown.
diff --git a/src/js_stream.cc b/src/js_stream.cc
@@ -162,6 +162,7 @@ void JSStream::Finish(const FunctionCallbackInfo<Value>& args) {
 
 
 void JSStream::ReadBuffer(const FunctionCallbackInfo<Value>& args) {
+  v8::TryCatch try_catch(args.GetIsolate());
   JSStream* wrap;
   ASSIGN_OR_RETURN_UNWRAP(&wrap, args.Holder());
 
@@ -182,6 +183,7 @@ void JSStream::ReadBuffer(const FunctionCallbackInfo<Value>& args) {
     len -= static_cast<int>(avail);
     wrap->EmitRead(avail, buf);
   }
+  if (try_catch.HasCaught()) try_catch.ReThrow();
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -162,6 +162,7 @@ void JSStream::Finish(const FunctionCallbackInfo<Value>& args) {`
`162`	`162`
`163`	`163`
`164`	`164`	`void JSStream::ReadBuffer(const FunctionCallbackInfo<Value>& args) {`
	`165`	`+ v8::TryCatch try_catch(args.GetIsolate());`
`165`	`166`	`JSStream* wrap;`
`166`	`167`	`ASSIGN_OR_RETURN_UNWRAP(&wrap, args.Holder());`
`167`	`168`
`@@ -182,6 +183,7 @@ void JSStream::ReadBuffer(const FunctionCallbackInfo<Value>& args) {`
`182`	`183`	`len -= static_cast<int>(avail);`
`183`	`184`	`wrap->EmitRead(avail, buf);`
`184`	`185`	`}`
	`186`	`+ if (try_catch.HasCaught()) try_catch.ReThrow();`
`185`	`187`	`}`
`186`	`188`
`187`	`189`