Move constant expressions to left-hand-side of conditional comparisons

jayaddison · jayaddison · commit 0b3d49231be4 · 2021-02-06T15:40:25.000Z
These constant expressions are read-only; a single-character typo or other mistake leading to the equality operator becoming an assignment operator would therefore be caught at compile-time by applying this change
diff --git a/src/large_pages/node_large_page.cc b/src/large_pages/node_large_page.cc
@@ -262,16 +262,16 @@ bool IsTransparentHugePagesEnabled() {
   // https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/mm/huge_memory.c?id=13391c60da3308ed9980de0168f74cce6c62ac1d#n163
   const char* filename = "/sys/kernel/mm/transparent_hugepage/enabled";
   std::ifstream config_stream(filename, std::ios::in);
-  if (config_stream.good() == false) {
+  if (false == config_stream.good()) {
     PrintWarning("could not open /sys/kernel/mm/transparent_hugepage/enabled");
     return false;
   }
 
   std::string token;
   config_stream >> token;
-  if (token == "[always]") return true;
+  if ("[always]" == token) return true;
   config_stream >> token;
-  if (token == "[madvise]") return true;
+  if ("[madvise]" == token) return true;
   return false;
 }
 #elif defined(__FreeBSD__)
