buffer: increase coverage by removing dead code

decareano · refack · commit 08984b26d351 · 2017-09-01T17:33:33.000-04:00
buffer.js:L196 `if (value == null)` guarantees `obj != null` so L406+L418 are unnecessary. PR-URL: #15100 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -404,17 +404,15 @@ function fromObject(obj) {
     return b;
   }
 
-  if (obj != null) {
-    if (obj.length !== undefined || isAnyArrayBuffer(obj.buffer)) {
-      if (typeof obj.length !== 'number' || obj.length !== obj.length) {
-        return new FastBuffer();
-      }
-      return fromArrayLike(obj);
+  if (obj.length !== undefined || isAnyArrayBuffer(obj.buffer)) {
+    if (typeof obj.length !== 'number' || obj.length !== obj.length) {
+      return new FastBuffer();
     }
+    return fromArrayLike(obj);
+  }
 
-    if (obj.type === 'Buffer' && Array.isArray(obj.data)) {
-      return fromArrayLike(obj.data);
-    }
+  if (obj.type === 'Buffer' && Array.isArray(obj.data)) {
+    return fromArrayLike(obj.data);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -404,17 +404,15 @@ function fromObject(obj) {`
`404`	`404`	`return b;`
`405`	`405`	`}`
`406`	`406`
`407`		`- if (obj != null) {`
`408`		`- if (obj.length !== undefined \|\| isAnyArrayBuffer(obj.buffer)) {`
`409`		`- if (typeof obj.length !== 'number' \|\| obj.length !== obj.length) {`
`410`		`- return new FastBuffer();`
`411`		`- }`
`412`		`- return fromArrayLike(obj);`
	`407`	`+ if (obj.length !== undefined \|\| isAnyArrayBuffer(obj.buffer)) {`
	`408`	`+ if (typeof obj.length !== 'number' \|\| obj.length !== obj.length) {`
	`409`	`+ return new FastBuffer();`
`413`	`410`	`}`
	`411`	`+ return fromArrayLike(obj);`
	`412`	`+ }`
`414`	`413`
`415`		`- if (obj.type === 'Buffer' && Array.isArray(obj.data)) {`
`416`		`- return fromArrayLike(obj.data);`
`417`		`- }`
	`414`	`+ if (obj.type === 'Buffer' && Array.isArray(obj.data)) {`
	`415`	`+ return fromArrayLike(obj.data);`
`418`	`416`	`}`
`419`	`417`	`}`
`420`	`418`