url: simplify loop in parser

tniessen · MylesBorins · commit 07e4ba2519b9 · 2018-02-21T10:18:48.000-05:00
PR-URL: #18468 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/url.js b/lib/url.js
@@ -883,7 +883,7 @@ Url.prototype.resolveObject = function resolveObject(relative) {
 
   // if the path is allowed to go above the root, restore leading ..s
   if (!mustEndAbs && !removeAllDots) {
-    for (; up--; up) {
+    while (up--) {
       srcPath.unshift('..');
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -883,7 +883,7 @@ Url.prototype.resolveObject = function resolveObject(relative) {`
`883`	`883`
`884`	`884`	`// if the path is allowed to go above the root, restore leading ..s`
`885`	`885`	`if (!mustEndAbs && !removeAllDots) {`
`886`		`- for (; up--; up) {`
	`886`	`+ while (up--) {`
`887`	`887`	`srcPath.unshift('..');`
`888`	`888`	`}`
`889`	`889`	`}`