First shot at actually resolving labels w/tests.

phillipj · phillipj · commit a24da27bd3a6 · 2016-04-10T12:43:06.000+02:00
Needs more work:
    - doesn't handle any C++ changes
    - changes to ./lib/_*.js and ./lib/internal has to be mapped manually,
      e.g. currently changes to ./lib/_stream_readable.js would be resolved to
      a "_stream_readable" label
diff --git a/lib/githubClient.js b/lib/githubClient.js
@@ -2,6 +2,8 @@
 
 const GitHub = require('github')
 
+const token = process.env.GITHUB_TOKEN || ''
+
 const githubClient = new GitHub({
   version: '3.0.0',
   protocol: 'https',
@@ -12,9 +14,11 @@ const githubClient = new GitHub({
   }
 })
 
-githubClient.authenticate({
-  type: 'oauth',
-  token: process.env.GITHUB_TOKEN
-})
+if (token) {
+  githubClient.authenticate({
+    type: 'oauth',
+    token: token
+  })
+}
 
-module.exports = githubClient;
+module.exports = githubClient
diff --git a/lib/nodeRepo.js b/lib/nodeRepo.js
@@ -1,8 +1,10 @@
 'use strict'
 
+const path = require('path')
+
 const githubClient = require('./githubClient')
 
-function resolvePrLabels(prId, cb) {
+function findLabelsForPr (prId, cb) {
   githubClient.pullRequests.getFiles({
     user: 'nodejs',
     repo: 'node',
@@ -12,10 +14,43 @@ function resolvePrLabels(prId, cb) {
       return cb(err)
     }
 
-    const filenamesChanged = res.map((fileMeta) => fileMeta.filename)
+    const filepathsChanged = res.map((fileMeta) => fileMeta.filename)
 
-    cb(err, filenamesChanged)
+    cb(err, resolveLabels(filepathsChanged))
   })
 }
 
-exports.resolvePrLabels = resolvePrLabels;
+function resolveLabels (filepathsChanged) {
+  const affectedRootDirs = filepathsChanged.reduce(reduceToRootDirs, {})
+  let labels = []
+
+  if (isOnlyTests(affectedRootDirs)) {
+    labels.push('test')
+  } else if (hasCoreModules(affectedRootDirs)) {
+    labels.push.apply(labels, coreModuleLabels(filepathsChanged))
+  }
+
+  return labels
+}
+
+function coreModuleLabels (filepathsChanged) {
+  return filepathsChanged.filter((filepath) => filepath.startsWith('lib'))
+                         .map((filepath) => path.basename(filepath, '.js'))
+}
+
+function hasCoreModules (affectedRootDirs) {
+  return !!affectedRootDirs.lib
+}
+
+function isOnlyTests (affectedRootDirs) {
+  return affectedRootDirs.test && Object.keys(affectedRootDirs).length === 1
+}
+
+function reduceToRootDirs (dirs, filepath) {
+  const rootDirForFile = filepath.split(path.sep)[0]
+  dirs[rootDirForFile] = true
+  return dirs
+}
+
+exports.findLabelsForPr = findLabelsForPr
+exports.resolveLabels = resolveLabels
diff --git a/package.json b/package.json
@@ -4,7 +4,8 @@
   "description": "Node.js GitHub Bot",
   "scripts": {
     "start": "node server.js",
-    "test": "standard"
+    "test": "standard && tap test/*.test.js",
+    "test:watch": "nodemon -q -x 'npm test'"
   },
   "engines": {
     "node": ">= 4.2.0"
@@ -20,6 +21,9 @@
     "travis-ci": "^2.1.0"
   },
   "devDependencies": {
-    "standard": "^6.0.7"
+    "ava": "^0.14.0",
+    "nodemon": "^1.9.1",
+    "standard": "^6.0.7",
+    "tap": "^5.7.1"
   }
 }
diff --git a/server.js b/server.js
@@ -5,7 +5,6 @@ require('dotenv').load({ silent: true })
 const express = require('express')
 const bodyParser = require('body-parser')
 
-const pollTravis = require('./lib/pollTravis')
 const nodeRepo = require('./lib/nodeRepo')
 
 const captureRaw = (req, res, buffer) => { req.raw = buffer }
@@ -27,10 +26,14 @@ app.listen(port, () => {
 })
 
 app.get('/labels/:prId', (req, res) => {
-  nodeRepo.resolvePrLabels(req.params.prId, (err, labels) => {
-    const statusCode = err ? 500 : 200;
+  nodeRepo.findLabelsForPr(req.params.prId, (err, labels) => {
+    let statusCode = 200
 
-    res.json(labels)
-    res.status(statusCode).end()
+    if (err) {
+      statusCode = 500
+      console.log('Error while finding labels', err)
+    }
+
+    res.status(statusCode).json(labels)
   })
 })
diff --git a/test/nodeRepo.test.js b/test/nodeRepo.test.js
@@ -0,0 +1,30 @@
+'use strict'
+
+const tap = require('tap')
+
+const nodeRepo = require('../lib/nodeRepo')
+
+tap.test('label: "test" when only ./test/ files has been changed', (t) => {
+  const labels = nodeRepo.resolveLabels([
+    'test/debugger/test-debugger-pid.js',
+    'test/debugger/test-debugger-repl-break-in-module.js',
+    'test/debugger/test-debugger-repl-term.js'
+  ])
+
+  t.same(labels, ['test'])
+
+  t.end()
+})
+
+tap.test('label: "repl" when ./lib/repl.js has been changed', (t) => {
+  const labels = nodeRepo.resolveLabels([
+    'lib/repl.js',
+    'test/debugger/test-debugger-pid.js',
+    'test/debugger/test-debugger-repl-break-in-module.js',
+    'test/debugger/test-debugger-repl-term.js'
+  ])
+
+  t.same(labels, ['repl'])
+
+  t.end()
+})
