test: fix tests and lint

evanlucas · evanlucas · commit 034d43e555dd · 2016-04-26T02:05:56.000-05:00
diff --git a/format.js b/format.js
@@ -5,7 +5,6 @@ const diff = require('./diff')
 const info = require('./info')
 
 const fail = chalk.red('✖')
-const pass = chalk.green('✔')
 
 function line(obj) {
   return obj.lineNum ? obj.lineNum : ''
@@ -19,14 +18,6 @@ function rpad(str, max) {
   return str
 }
 
-function lpad(str, max) {
-  const diff = max - str.length + 1
-  if (diff > 0) {
-    return `${' '.repeat(diff)}${str}`
-  }
-  return str
-}
-
 function getInfo(s) {
   return rpad(info[s] || '', 40)
 }
@@ -37,7 +28,6 @@ exports.default = (obj, commit) => {
     ? chalk.grey(rpad(`${line(obj)}:0`, 6))
     : rpad('', 6)
 
-  const str = obj.str
   const i = getInfo(obj.code)
 
   return `  ${fail}  ${lin}  ${i} ${t}`
@@ -51,7 +41,6 @@ exports.ETITLETOOLONG = (obj, commit) => {
   const t = chalk.red('ETITLETOOLONG')
   const lin = chalk.grey(rpad(`${line(obj)}:50`, 6))
   const str = obj.str
-  const l = str.length
   const i = getInfo('ETITLETOOLONG')
   return `  ${fail}  ${lin}  ${i} ${t}
      ${diff.ETITLETOOLONG(str)}`
@@ -60,11 +49,9 @@ exports.ETITLETOOLONG = (obj, commit) => {
 exports.EINVALIDSUBSYSTEM = (obj, commit) => {
   const t = chalk.red('EINVALIDSUBSYSTEM')
   const title = commit.title
-  const subs = commit.subsystems.join(',')
   const col = title.indexOf(obj.str)
   const lin = chalk.grey(rpad(`${line(obj)}:${col}`, 6))
   const str = obj.str
-  const l = str.length
   const i = getInfo('EINVALIDSUBSYSTEM')
   return `  ${fail}  ${lin}  ${i} ${t}
      ${diff.EINVALIDSUBSYSTEM(str, title)}`
@@ -74,7 +61,6 @@ exports.ELINETOOLONG = (obj, commit) => {
   const t = chalk.red('ELINETOOLONG')
   const lin = chalk.grey(rpad(`${line(obj)}:72`, 6))
   const str = obj.str
-  const l = str.length
   const i = getInfo('ELINETOOLONG')
   return `  ${fail}  ${lin}  ${i} ${t}
      ${diff.ELINETOOLONG(str)}`
@@ -109,6 +95,5 @@ exports.EMETAORDER = (obj, commit) => {
   const t = chalk.red('EMETAORDER')
   const lin = chalk.grey(rpad(`${line(obj)}:0`, 6))
   const i = getInfo('EMETAORDER')
-  const str = obj.str
   return `  ${fail}  ${lin}  ${i} ${t}`
 }
diff --git a/test.js b/test.js
@@ -68,8 +68,7 @@ test('commit', (t) => {
   t.equal(c.date, 'Tue Mar 29 08:09:37 2016 -0500', 'date')
   t.deepEqual(c.subsystems, [], 'subsystems')
   t.equal(c.pr, 'https://github.com/nodejs/node/pull/5947', 'pr')
-  t.equal(c.warnings.length, 1, 'warnings.length')
-  t.equal(c.warnings[0].code, 'ETITLETOOLONG', 'code')
+  t.equal(c.warnings.length, 0, 'warnings.length')
   t.equal(c.revert, true, 'revert')
 
   c = new Commit(str3)
