You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We can also consider joining linter CI and doc CI in a new CI job. Previously, we used linter CI also for benchmark PRs, but now we tend to make benchmarks fully testable, so the separate linter CI job remains useful only for the docs with code fragments. We can as well make these two CI joined in some special light CI job for docs.
Activity
gibfahn commentedon Oct 22, 2017
Okay, so how should we do this?
I guess options are:
node-test-pull-requestto only run linter + doc linter (off by default).How do you run the doc linting btw? I should really know, but I'm not sure. Is it a
maketarget?joyeecheung commentedon Oct 22, 2017
@gibfahn A make target indeded.See nodejs/node#16377 (need to fix the shell quirks first)
joyeecheung commentedon Jan 14, 2018
It's already up and running in https://ci.nodejs.org/job/node-test-pull-request-lite/. This can be closed now.