From 8f78805acfe279bf37292b6fb6ba26d7a9001240 Mon Sep 17 00:00:00 2001 From: Ian Hattendorf Date: Mon, 11 Feb 2019 09:16:10 -0700 Subject: [PATCH] Fix macOS and Windows Electron 4 builds --- generate/templates/templates/binding.gyp | 4 ++-- vendor/libgit2.gyp | 9 +++++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/generate/templates/templates/binding.gyp b/generate/templates/templates/binding.gyp index c15a7ec55..f67cf2e31 100644 --- a/generate/templates/templates/binding.gyp +++ b/generate/templates/templates/binding.gyp @@ -94,7 +94,7 @@ [ "OS=='mac'", { "conditions": [ - ["node_root_dir.split('/')[-1].startswith('iojs')", { + ["<(is_electron) == 1", { "include_dirs": [ "vendor/openssl/include" ], @@ -122,7 +122,7 @@ [ "OS=='win'", { "conditions": [ - ["node_root_dir.split('\\\\')[-1].startswith('iojs')", { + ["<(is_electron) == 1", { "include_dirs": ["vendor/openssl/include"], "libraries": [ "<(module_root_dir)/vendor/openssl/lib/libcrypto.lib", diff --git a/vendor/libgit2.gyp b/vendor/libgit2.gyp index fd5f93cd3..0bfc49c45 100644 --- a/vendor/libgit2.gyp +++ b/vendor/libgit2.gyp @@ -7,6 +7,7 @@ "library%": "static_library", "openssl_enable_asm%": 0, # only supported with the Visual Studio 2012 (VC11) toolchain. "gcc_version%": 0, + "is_electron%": "