Repository navigation
index.removeByPath stops execution #97
Description
trying to use removeByPath by using repo.openIndex, index.read, index.removeByPath and the scripts stops execution, no error, no logs, return code is 0.
nodegit@0.1.0
node v0.10.13
OS: OSX 10.8.5
var git = require('nodegit')
git.Repo.open(repoPath, function(openError, repo) {
if (openError) throw openError;
repo.openIndex(function(openIndexError, index) {
if (openIndexError) throw openIndexError;
index.read(function(readError) {
if (readError) throw readError;
index.removeByPath(fileName, function(removeByPathError,r) {
if (removeByPathError) throw removeByPathError;
console.log('ok');
});
});
});
});Steps to repro:
- set repoPath to the path of a checked out repo
- set fileName to the filename to delete from the repo
Expectations: prints 'ok' or throws removeByPathError
Actual: process stops without error.
Activity
nkallen commentedon Oct 1, 2013
Probably a segfault. I wont be able to get to this for a few days. You can speed up the process by running this in gdb and pasting the backtrace.
nkallen commentedon Oct 1, 2013
Actually not a segfault. It turns out
index.removeByPath(fileName)is not async; it doesn't take a callback, so just call it directly and it will throw if there is an error.Looking through the libgit2 source code, I believe this is correct behavior (it does not IO, unlike
index.addByPathwhich reads from the filesystem).dcolens commentedon Oct 2, 2013
damn stupid me!
Thanks :)
Did
On 01 Oct 2013, at 19:44, Nick Kallen notifications@github.com wrote: