Repository navigation
missing cstring #88
Description
At the moment I cannot get the master commit to build. It dies with the error:
[nodegit] Building native module.
make: Entering directory `/home/tim/git/nodegit/nodegit/build'
CXX(target) Release/obj.target/nodegit/src/wrapper.o
../src/wrapper.cc: In static member function ‘static v8::Handle<v8::Value> Wrapper::ToBuffer(const v8::Arguments&)’:
../src/wrapper.cc:71:99: error: ‘memcpy’ was not declared in this scope
memcpy(node::Buffer::Data(nodeBuffer), ObjectWrap::Unwrap<Wrapper>(args.This())->GetValue(), len);
^
make: *** [Release/obj.target/nodegit/src/wrapper.o] Error 1
make: Leaving directory `/home/tim/git/nodegit/nodegit/build'I updated the src/wrapper.cc file to include <cstring> to test and the compilation succeeded. Am I missing something or should I patch?
Activity
tbranyen commentedon Sep 8, 2013
Looks like @FrozenCow opened a PR for this. #89
nkallen commentedon Sep 8, 2013
merged