Skip to content

openIndex(), createCommit() missing from API documentation #634

Closed

Description

@vsivsi

I expected to find documentation for repository#openIndex() and repository#createCommit() in the API documentation after encountering them in the example code.

These appear to be completely absent from the documentation, which is pretty surprising since they seem like key functionality that appears to have been added way back in or before v0.2.

Activity

  1. changed the title [-]openIndex() missing from API documentation[/-] [+]openIndex(), createCommit() missing from API documentation[/+] on Jul 4, 2015
  2. nopnop commented on Sep 27, 2015

    @nopnop

    Yes, this is confusing. Related: #197 and #198
    Maybe, the examples need to be updated ?

  3. tbranyen commented on Sep 27, 2015

    @tbranyen
    Member

    @vsivsi we auto-generate the documentation on the site, so it's entirely possible they are either missing JSDoc syntax, or we have a bug in the generator. Since they are not manually added, its not like we just forgot to add them.

  4. tbranyen commented on Sep 27, 2015

    @tbranyen
    Member

    https://github.com/nodegit/nodegit/blob/master/lib/repository.js#L22-L25

    ^^ As we can see here openIndex is indeed missing JSDoc syntax, which explains why it is omitted from the documentation.

  5. rcjsuen commented on Jan 29, 2017

    @rcjsuen
    Member

    createCommit is now on the website and the openIndex function has since been removed from Repository. Can we close this?

  6. tbranyen commented on Jan 29, 2017

    @tbranyen
    Member

    Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions