Skip to content

Build is broken on windows #565

Closed

Description

@maxkorp

Getting lots of libssh issues during compile, seems tied to the commit where libssh was updated from 1.4.3 to 1.5.0. Trying a rollback now.

Activity

  1. added a commit that references this issue on May 12, 2015
  2. tbranyen commented on May 12, 2015

    @tbranyen
    Member

    Huh, how is Appveyor passing then?

    For shame. 🍧

  3. maxkorp commented on May 12, 2015

    @maxkorp
    CollaboratorAuthor

    It's not even running the tests since the build fails. Since they don't run, they dont fail! At least as far as I can tell >.<

    (Either that or an error code is getting swallowed, which would be much more reasonable lol)

  4. maxkorp commented on May 12, 2015

    @maxkorp
    CollaboratorAuthor

    Confirmed, rolling back to 1.4.3 fixes it. I'll make a PR, but we'll leave it until we figure out the false positives.

  5. tbranyen commented on May 12, 2015

    @tbranyen
    Member

    I messed something up with:

    https://github.com/nodegit/nodegit/blob/master/package.json#L93

    it returns success during a failure 👎

  6. maxkorp commented on May 12, 2015

    @maxkorp
    CollaboratorAuthor

    Gotcha. Awesome lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions