getStatus hangs #537

Activity

1. tbranyen commented on Apr 11, 2015

   

   tbranyen

   on Apr 11, 2015

   Member

   More actions

   Looks to be a duplicate of: #497
2. AdamStone commented on Apr 11, 2015

   

   AdamStone

   on Apr 11, 2015

   Author

   More actions

   D'oh, I tried to search but I guess I was too focused on status/getStatus.

   For now I'll just use the workaround from #497 of putting process.exit() in the .done() method.
3. AdamStone

   closed this as completedon Apr 11, 2015
4. tommoor commented on Dec 7, 2016

   

   tommoor

   on Dec 7, 2016

   Last edited by tommoor

   More actions

   I'm still seeing this behavior in the latest 0.16 release - getStatus does not resolve sporadically - trying to dig into what might be causing this for us :(
5. heath-guidewire commented on Apr 6, 2017

   

   heath-guidewire

   on Apr 6, 2017

   Last edited by heath-guidewire

   More actions

   I'm still seeing this on 0.18.0. The first call to this method in my tests returns, the next one does not return and the .then() is not executed... same for any subsequent calls. It's almost like the first call leaves something in the thread that prevents any others from properly returning the promise
6. tommoor commented on Apr 6, 2017

   

   tommoor

   on Apr 6, 2017

   Last edited by tommoor

   More actions

   @heath-guidewire we ended up completely removing use of getStatus from our code, instead diffing the index to working tree using NodeGit.Diff. Maybe that's a strategy you could take…
7. heath-guidewire commented on Apr 6, 2017

   

   heath-guidewire

   on Apr 6, 2017

   Last edited by heath-guidewire

   More actions

   Is there an example for this? Basically I want to know whether there have been any changes in the repo from the checked out version so that I can determine that I have to create a commit or not.
8. tommoor commented on Apr 6, 2017

   

   tommoor

   on Apr 6, 2017

   More actions

   Not sure about examples, but there is a method for it which works well and provides similar results to getStatus with a bit of massaging http://www.nodegit.org/api/diff/#indexToWorkdir

   Something along the lines of:

   Git.Diff.indexToWorkdir(repo, null, yourDiffOptions)
   .then(diff => {
     const changes = {};
     for (let i = 0; i < diff.numDeltas(); i++) {
       const delta = diff.getDelta(i);
       const oldPath = delta.oldFile().path();
       const newPath = delta.newFile().path();
       const statusPath = oldPath || newPath;
       changes[statusPath] = delta.status();
     }
     return changes;
   })
     
9. heath-guidewire commented on Apr 6, 2017

   

   heath-guidewire

   on Apr 6, 2017

   More actions

   Hmm, even that command seems to have the same issue... Sometimes it works and sometimes it doesn't.
10. tommoor commented on Apr 6, 2017

    

    tommoor

    on Apr 6, 2017

    Last edited by tommoor

    More actions

    We've not seen any issues with that one (across tens of thousands of commits), I'd definitely check the rest of your code thoroughly, sounds like this might not be where your issue lies - most likely an unreturned promise.
11. heath-guidewire commented on Apr 6, 2017

    

    heath-guidewire

    on Apr 6, 2017

    Last edited by heath-guidewire

    More actions

    I'm seeing a weird issue where repository.refreshIndex() does not return: Here's the code I have

      let repository;
      return nodegit.Repository.open(gitRepoPath())
        .then(repo => {
          repository = repo;
          console.log('repo opened');
          return repository.refreshIndex()
            .then(index => {
              console.log('read index', index);
              const flags = nodegit.Diff.OPTION.SHOW_UNTRACKED_CONTENT | nodegit.Diff.OPTION.RECURSE_UNTRACKED_DIRS;
              const diffOptions = {flags};
              return nodegit.Diff.indexToWorkdir(repository, index, diffOptions)
                .then(diff => {
                  console.log('changes found', diff);
                  const changes = {};
                  for (let i = 0; i < diff.numDeltas(); i++) {
                    const delta = diff.getDelta(i);
                    const oldPath = delta.oldFile().path();
                    const newPath = delta.newFile().path();
                    const statusPath = oldPath || newPath;
                    changes[statusPath] = delta.status();
                  }
                  return changes;
                })
            })
        });
    

    I see the 'repo opened' message, but not the 'read index' message. Funny thing is that another method I have that uses refreshIndex() works. I swear I am totally missing something that's causing it to fail. Even using repository.index() seems to not return either.