Skip to content

Cannot create an instance of Packbuilder #507

Closed

Description

@stevenceuppens

var packbuilder = new NodeGit.Packbuilder();
results in -> [Error: A new GitPackbuilder cannot be instantiated.]

From the docs http://www.nodegit.org/api/#Packbuilder , it seems that Packbuilder only has Instance methods to use Packbuilder, and no Class methods to create an instance of it. I'm also not able to create a "new" instance of Packbuilder from Js, and can't find a reference on other objects to an existing instance.

Activity

  1. maxkorp commented on Mar 23, 2015

    @maxkorp
    Collaborator

    Hrm, it seems that git_packbuilder_new is probably ignored.

    If you can, clone the repo, take a look inside out generate/input/ descriptor.json file and see if thats set to be ignored. If it is, try taking it out and regenerating/compiling. That should add NodeGit.Packbuilder.create(). If that works, submit a PR, preferably with a test (or more) and we'll get it in asap. Otherwise, I'll make sure that gets moved near the top of the stack, but I don't know how quickly it will get implemented.

  2. tbranyen commented on Mar 24, 2015

    @tbranyen
    Member

    FYI I submitted a PR that adds this in: #513

  3. maxkorp commented on Mar 24, 2015

    @maxkorp
    Collaborator

    👍

  4. tbranyen commented on Mar 24, 2015

    @tbranyen
    Member

    Closed via: c0922f7

    Usage:

    var packBuilder = NodeGit.Packbuilder.create(someRepositoryObject);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions